mir_build: Rename TestCase to TestableCase#150051
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 17, 2025
Merged
Conversation
Collaborator
|
Some changes occurred in match lowering cc @Nadrieril |
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Nadrieril
reviewed
Dec 16, 2025
Comment on lines
-1264
to
+1267
| enum TestCase<'tcx> { | ||
| enum TestableCase<'tcx> { |
Member
There was a problem hiding this comment.
For me TestableCase is more confusing than TestCase. I would prefer TestOutcome for example
Member
Author
There was a problem hiding this comment.
Hmm, my main motivation is to get rid of the Test prefix, because that's the part that keeps confusing me.
I think I would find TestOutcome even more confusing, because of TestBranch.
Member
|
r? me |
Member
Author
|
I would like to give this thing a better name, but I think it's only worth changing if we can agree on a new name that's clearly better. So I would be fine with closing this for now, since it would conflict with some other simplifications/improvements that I'm investigating. |
Member
|
I can live with @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 17, 2025
mir_build: Rename `TestCase` to `TestableCase` In the spirit of rust-lang#149946, this is another renaming of something I've always found confusing. When lowering match conditions, there is a subtle distinction between the kind of *test* being performed (on a scrutinee place), the possible outcomes of that test, and the different “cases” (corresponding to pattern nodes) that the test is distinguishing. Cases imply a particular preferred test, but once a test is chosen it can also interact with other cases as well. I have often mixed up `TestKind` and `TestCase`, since the names are so similar, and they share several variant names. Therefore, this PR renames `TestCase` to `TestableCase`, to emphasise that these are the things selected by whatever test is being performed. There should be no change to compiler behaviour.
This was referenced Dec 17, 2025
bors
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup of 4 pull requests Successful merges: - #149919 (Correctly encode doc attribute metadata) - #150051 (mir_build: Rename `TestCase` to `TestableCase`) - #150088 (miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently) - #150096 (Revert #148937) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup merge of #150051 - Zalathar:thir-pat, r=Nadrieril mir_build: Rename `TestCase` to `TestableCase` In the spirit of #149946, this is another renaming of something I've always found confusing. When lowering match conditions, there is a subtle distinction between the kind of *test* being performed (on a scrutinee place), the possible outcomes of that test, and the different “cases” (corresponding to pattern nodes) that the test is distinguishing. Cases imply a particular preferred test, but once a test is chosen it can also interact with other cases as well. I have often mixed up `TestKind` and `TestCase`, since the names are so similar, and they share several variant names. Therefore, this PR renames `TestCase` to `TestableCase`, to emphasise that these are the things selected by whatever test is being performed. There should be no change to compiler behaviour.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#149919 (Correctly encode doc attribute metadata) - rust-lang/rust#150051 (mir_build: Rename `TestCase` to `TestableCase`) - rust-lang/rust#150088 (miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently) - rust-lang/rust#150096 (Revert rust-lang/rust#148937) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of #149946, this is another renaming of something I've always found confusing.
When lowering match conditions, there is a subtle distinction between the kind of test being performed (on a scrutinee place), the possible outcomes of that test, and the different “cases” (corresponding to pattern nodes) that the test is distinguishing. Cases imply a particular preferred test, but once a test is chosen it can also interact with other cases as well.
I have often mixed up
TestKindandTestCase, since the names are so similar, and they share several variant names. Therefore, this PR renamesTestCasetoTestableCase, to emphasise that these are the things selected by whatever test is being performed.There should be no change to compiler behaviour.