Add test for never type fallback in try blocks with Into<!>
#150434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-lang#125364 This test verifies that the never type fallback behavior in try blocks with `Into<!>` bounds works correctly across different editions: - Edition 2021: Fallback to `()` causes type error - Edition 2024: Fallback to `!` compiles successfully
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
Collaborator
|
Contributor
Author
WaffleLapkin
approved these changes
Dec 27, 2025
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Dec 28, 2025
Rollup merge of #150434 - AprilNEA:test-125364-never-type-try-blocks, r=WaffleLapkin Add test for never type fallback in try blocks with `Into<!>` ### Summary Adds UI tests for issue #125364, which involves the interaction between never type fallback, try blocks, and `From`/`Into` trait bounds. ### Changes - Added `tests/ui/never_type/try-block-never-type-fallback.rs` - Tests both edition 2021 (where the issue manifests) and edition 2024 (where it's fixed) ### Issue Closes #125364 ### Testing ```bash ./x test tests/ui/never_type/try-block-never-type-fallback.rs ``` Both test variants pass: e2021: Correctly fails with expected error e2024: Compiles successfully (check-pass) ### Notes This test documents the edition-dependent behavior of never type fallback in try blocks, as requested in the original issue. cc `@WaffleLapkin`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds UI tests for issue #125364, which involves the interaction between
never type fallback, try blocks, and
From/Intotrait bounds.Changes
tests/ui/never_type/try-block-never-type-fallback.rsIssue
Closes #125364
Testing
./x test tests/ui/never_type/try-block-never-type-fallback.rsBoth test variants pass:
e2021: Correctly fails with expected error
e2024: Compiles successfully (check-pass)
Notes
This test documents the edition-dependent behavior of never type fallback in try blocks, as requested in the original issue.
cc @WaffleLapkin