Skip to content

./x check miri: enable check_only feature#150694

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:miri-check
Jan 8, 2026
Merged

./x check miri: enable check_only feature#150694
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:miri-check

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Jan 5, 2026 •
edited
Loading

With this, we should no longer need to turn off the default features, so we can undo #149550.

@bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended?

FWIW we could now remove default_features from run_tool_check_step. Not sure if that's worth it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

clubby789
clubby789 approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@clubby789 clubby789 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; I think it's more useful to keep default_features around. Going to pass this on for the testing:
r? @bjorn3

View changes since this review

@rustbot rustbot assigned bjorn3 and unassigned clubby789 Jan 5, 2026
bjorn3
bjorn3 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@bjorn3 bjorn3 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works fine with ./x.py check --compile-time-deps and inside rust-analyzer. Both before and after this PR miri takes 5s for compiling the build deps.

View changes since this review

@bjorn3
Copy link
Member

bjorn3 commented Jan 7, 2026

@bors r=clubby789,bjorn3

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit 38ab519 has been approved by clubby789,bjorn3

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit 38ab519 has been approved by clubby789,bjorn3

It is now in the queue for this repository.

jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 8, 2026
@jhpratt
Rollup merge of rust-lang#150694 - w/mismatch, r=clubby789,bjorn3
f510c03 
./x check miri: enable check_only feature

Commit rust-lang#147526 removed the following code and replaced it with the `AllocatorMethod`. However, its input is empty, resulting in behavior inconsistent with the previous code.

```rust
  create_wrapper_function(
      tcx,
      &cx,
      &mangle_internal_symbol(tcx, "__rust_alloc_error_handler"),
      Some(&mangle_internal_symbol(tcx, alloc_error_handler_name(alloc_error_handler_kind))),
      &[usize, usize], // size, align
      None,
      true,
      &CodegenFnAttrs::new(),
  );
  ```

  resolves rust-lang#150755
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150694 - miri-check, r=clubby789,bjorn3
221bab0 
./x check miri: enable check_only feature

With this, we should no longer need to turn off the default features, so we can undo rust-lang#149550.

@bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended?

FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150694 - miri-check, r=clubby789,bjorn3
3734e43 
./x check miri: enable check_only feature

With this, we should no longer need to turn off the default features, so we can undo rust-lang#149550.

@bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended?

FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
@rust-bors
Auto merge of #150801 - matthiaskrgr:rollup-o7LL17D, r=matthiaskrgr
9147292 
Rollup of 11 pull requests

Successful merges:

 - #149976 (Add waker_fn and local_waker_fn to std::task)
 - #150074 (Update provider API docs)
 - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets)
 - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm)
 - #150569 (Ensure that static initializers are acyclic for NVPTX)
 - #150607 (Add amdgpu_dispatch_ptr intrinsic)
 - #150694 (./x check miri: enable check_only feature)
 - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`)
 - #150736 (Add AtomicPtr::null)
 - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl)
 - #150789 (Fix copy-n-paste error in `vtable_for` docs)

r? @ghost
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Merged
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
@rust-bors
Auto merge of #150810 - matthiaskrgr:rollup-fXh6V3q, r=matthiaskrgr
4586feb 
Rollup of 10 pull requests

Successful merges:

 - #149976 (Add waker_fn and local_waker_fn to std::task)
 - #150074 (Update provider API docs)
 - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets)
 - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm)
 - #150569 (Ensure that static initializers are acyclic for NVPTX)
 - #150694 (./x check miri: enable check_only feature)
 - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`)
 - #150736 (Add AtomicPtr::null)
 - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl)
 - #150789 (Fix copy-n-paste error in `vtable_for` docs)

r? @ghost
@rust-bors rust-bors bot merged commit 219d95e into rust-lang:main Jan 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
rust-timer added a commit that referenced this pull request Jan 8, 2026
@rust-timer
Unrolled build for #150694
de215f0 
Rollup merge of #150694 - miri-check, r=clubby789,bjorn3

./x check miri: enable check_only feature

With this, we should no longer need to turn off the default features, so we can undo #149550.

@bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended?

FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
@RalfJung RalfJung deleted the miri-check branch January 11, 2026 07:38
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clubby789 clubby789 clubby789 approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

@bjorn3 bjorn3

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @rustbot @bjorn3 @bors @clubby789