std: sys: fs: uefi: Implement File::seek#150918

Ayush1325 · 2026-01-10T11:00:25Z

Tested using OVMF on QEMU.

@rustbot label +O-UEFI

rustbot · 2026-01-10T11:00:31Z

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jhpratt · 2026-01-10T16:32:02Z

@bors r=nicholasbishop,jhpratt rollup

rust-bors · 2026-01-10T16:32:06Z

📌 Commit 7c428e0 has been approved by nicholasbishop,jhpratt

It is now in the queue for this repository.

joboet · 2026-01-10T16:38:15Z

library/std/src/sys/fs/uefi.rs

+
+        let off = match pos {
+            SeekFrom::Start(p) => p,
+            SeekFrom::End(p) => {


You could special-case SeekFrom::End(0) here and use 0xFFFFFFFFFFFFFFFF as offset, since that causes the position to be set to the end of the file without having to look up the length.

jhpratt · 2026-01-10T16:41:11Z

Take the previous recommendation at your own discretion. Feel free to approve the PR yourself either way.

@bors r- delegate+

rust-bors · 2026-01-10T16:41:15Z

Commit 7c428e0 has been unapproved.

- Tested using OVMF on QEMU. Signed-off-by: Ayush Singh <[email protected]>

jhpratt · 2026-01-10T16:46:30Z

@bors r+

rust-bors · 2026-01-10T16:46:34Z

📌 Commit 6878e73 has been approved by jhpratt

It is now in the queue for this repository.

@rustbot

std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

@rustbot

std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150786 (mGCA: Support array expression as direct const arguments) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) r? @ghost

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

@rustbot

Rollup merge of #150918 - uefi-fs-seek, r=jhpratt std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

rustbot assigned jhpratt Jan 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 10, 2026

rustbot added the O-UEFI UEFI label Jan 10, 2026

Ayush1325 mentioned this pull request Jan 10, 2026

Tracking Issue for uefi-std #100499

Open

nicholasbishop approved these changes Jan 10, 2026

View reviewed changes

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026

rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026

joboet reviewed Jan 10, 2026

View reviewed changes

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2026

std: sys: fs: uefi: Implement File::seek

6878e73

- Tested using OVMF on QEMU. Signed-off-by: Ayush Singh <[email protected]>

Ayush1325 force-pushed the uefi-fs-seek branch from 7c428e0 to 6878e73 Compare January 10, 2026 16:43

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 10, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150918 - uefi-fs-seek, r=jhpratt

23cfb4b

std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

Zalathar mentioned this pull request Jan 11, 2026

[EXPERIMENT] Rollup of 15 pull requests #150948

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150918 - uefi-fs-seek, r=jhpratt

2562a3a

std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

Zalathar mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150952

Closed

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150957

Merged

rust-bors bot merged commit 3b1f270 into rust-lang:main Jan 11, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 11, 2026

rust-timer added a commit that referenced this pull request Jan 11, 2026

Unrolled build for #150918

3586a8c

Rollup merge of #150918 - uefi-fs-seek, r=jhpratt std: sys: fs: uefi: Implement File::seek - Tested using OVMF on QEMU. @rustbot label +O-UEFI

Ayush1325 deleted the uefi-fs-seek branch January 11, 2026 16:35

github-actions bot mentioned this pull request Jan 27, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

std: sys: fs: uefi: Implement File::seek#150918