Skip to content

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Feb 2, 2026

This renames rustc_query_system::query::plumbing to execution and splits rustc_middle::query::plumbing into macros and system modules. This reduces the modules named plumbing in the query system from 3 to 1.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2026
@Zoxc Zoxc marked this pull request as ready for review February 2, 2026 20:04
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 2, 2026

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
Rename and split some modules in the query system
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 2, 2026
@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 2, 2026

cc @nnethercote @Zalathar

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

💔 Test for 99b5429 failed: CI

@Zalathar
Copy link
Member

Zalathar commented Feb 2, 2026

I like the motivation (not having three plumbing modules, and splitting things up a bit), but I'm concerned that these particular names/splits might end up being differently-confusing instead of better.

I'll try to go into more detail later when I have time.

@nnethercote
Copy link
Contributor

r? @Zalathar

@rustbot rustbot assigned Zalathar and unassigned mati865 Feb 2, 2026
@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 2, 2026

I think the execution one is ok, as that is the main supporting part for execution queries. I'm not too worried about the other being side grades, given that we probably want some reorganization if we merge rustc_query_system anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants