Couple of cleanups and optimizations around MIR encoding#152096
Couple of cleanups and optimizations around MIR encoding#152096rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Couple of cleanups and optimizations around MIR encoding
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (9b86a67): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.0%, secondary 4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.2%, secondary -0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.808s -> 471.843s (-0.83%) |
It isn't called anywhere anymore.
5b63d3f to
d1891b8
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
We only use mir_for_ctfe for them anyway in instance_mir. This does prevent MIR inlining of constructor calls, but constructor calls that are inlinable during MIR optimizations are rare anyway given that MIR building already inlines all direct calls to constructors.
d1891b8 to
05921d4
Compare
|
@bors r=oli-obk |
This comment has been minimized.
This comment has been minimized.
Couple of cleanups and optimizations around MIR encoding
|
@bors yield |
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #152156. |
This comment has been minimized.
This comment has been minimized.
Couple of cleanups and optimizations around MIR encoding
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 1f94428 failed: CI. Failed job:
|
|
again, cc @GuillaumeGomez lets remove the test |
|
Hum no. This one is useful. Wth is going with Rust CI. This one very rarely failed before... |
|
Just disable it temporarily then :3 |
|
I'm pretty sure another test will become flaky in its stead... |
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 66daca1 (parent) -> f889772 (this PR) Test differencesShow 269 test diffsStage 2
(and 73 additional test diffs) Additionally, 96 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f889772d6500faebcac5bb70fa44b5e6581c38cd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (f889772): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.0%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.2%, secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.029s -> 472.84s (-0.25%) |
No description provided.