Skip to content

Couple of cleanups and optimizations around MIR encoding#152096

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
bjorn3:mir_encoding_cleanups
Feb 5, 2026
Merged

Couple of cleanups and optimizations around MIR encoding#152096
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
bjorn3:mir_encoding_cleanups

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 4, 2026

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@bjorn3
Copy link
Member Author

bjorn3 commented Feb 4, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 4, 2026
Couple of cleanups and optimizations around MIR encoding
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2026
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with perf happy

r? oli-obk

View changes since this review

@rustbot rustbot assigned oli-obk and unassigned BoxyUwU Feb 4, 2026
@rust-bors

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 4, 2026

☀️ Try build successful (CI)
Build commit: 9b86a67 (9b86a6753da5ada177cf50d80831a569b0834671, parent: 794495e2b4a1353cf7b66ffc55f0e755490af2cc)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9b86a67): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 1
Improvements ✅
(secondary)
-0.2% [-0.4%, -0.1%] 4
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 1

Max RSS (memory usage)

Results (primary -3.0%, secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.6% [4.7%, 6.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.2%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.5%, -0.0%] 39
Improvements ✅
(secondary)
-0.5% [-1.5%, -0.0%] 39
All ❌✅ (primary) -0.2% [-0.5%, -0.0%] 39

Bootstrap: 475.808s -> 471.843s (-0.83%)
Artifact size: 398.08 MiB -> 398.07 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2026
It isn't called anywhere anymore.
@bjorn3 bjorn3 force-pushed the mir_encoding_cleanups branch from 5b63d3f to d1891b8 Compare February 4, 2026 15:58
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

We only use mir_for_ctfe for them anyway in instance_mir. This does
prevent MIR inlining of constructor calls, but constructor calls that
are inlinable during MIR optimizations are rare anyway given that MIR
building already inlines all direct calls to constructors.
@bjorn3 bjorn3 force-pushed the mir_encoding_cleanups branch from d1891b8 to 05921d4 Compare February 4, 2026 16:01
@bjorn3
Copy link
Member Author

bjorn3 commented Feb 4, 2026

@bors r=oli-obk

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 4, 2026

📌 Commit 05921d4 has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
Couple of cleanups and optimizations around MIR encoding
@JonathanBrouwer
Copy link
Contributor

@bors yield
Letting the rollup with two flaky test fixes go first

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 5, 2026

Auto build cancelled. Cancelled workflows:

The next pull request likely to be tested is #152156.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 5, 2026
Couple of cleanups and optimizations around MIR encoding
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260123.484
Commit: 6bd6555ca37d84114959e1c76d2c01448ff61c5d
Build Date: 2026-01-23T19:41:17Z
Worker ID: {f7649715-6f86-4372-97b5-c28b8d3a0c9c}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS
---
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   9 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/drain_collect.fixed ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/eager_transmute.rs ... ok
tests/ui/empty_docs.rs ... ok
---
..............................................     (146/146)

======== tests/rustdoc-gui/search-filter.goml ========

[ERROR] line 48: Error: The CSS selector "#search-tabs .count.loading" still exists: for command `wait-for-false: "#search-tabs .count.loading"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=test>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 5, 2026

💔 Test for 1f94428 failed: CI. Failed job:

@lqd
Copy link
Member

lqd commented Feb 5, 2026

again, cc @GuillaumeGomez

lets remove the test

@GuillaumeGomez
Copy link
Member

Hum no. This one is useful. Wth is going with Rust CI. This one very rarely failed before...

@lqd
Copy link
Member

lqd commented Feb 5, 2026

Just disable it temporarily then :3

@GuillaumeGomez
Copy link
Member

I'm pretty sure another test will become flaky in its stead...

@JonathanBrouwer
Copy link
Contributor

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 5, 2026

☀️ Test successful - CI
Approved by: oli-obk
Duration: 3h 14m 13s
Pushing f889772 to main...

@rust-bors rust-bors bot merged commit f889772 into rust-lang:main Feb 5, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 66daca1 (parent) -> f889772 (this PR)

Test differences

Show 269 test diffs

Stage 2

  • [debuginfo-cdb] tests/debuginfo/associated-const-bindings.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/basic-types-globals-metadata.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/basic-types-metadata.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/basic-types-mut-globals.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/basic-types.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/borrowed-basic.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/borrowed-c-style-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/borrowed-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/borrowed-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/borrowed-unique-basic.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/box.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/by-value-non-immediate-argument.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/captured-fields-1.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/captured-fields-2.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/collapse-debuginfo-external-attr.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/collapse-debuginfo-external-flag-overriden-by-attr.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/collapse-debuginfo-no-attr.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/collapse-debuginfo-static-external.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/constant-ordering-prologue.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/coroutine-closure.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/coroutine-locals.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/cross-crate-type-uniquing.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/drop-locations.rs: [missing] -> ignore (ignored always ((broken, see Stepping with "next" in a debugger skips past end-of-scope drops #128971))) (J0)
  • [debuginfo-cdb] tests/debuginfo/duration-type.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/embedded-visualizer.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/empty-string.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/enum-thinlto.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/evec-in-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/extern-c-fn.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/fn_ptr.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/function-arg-initialization.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/function-call.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/function-names.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/function-prologue-stepping-regular.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/gdb-char.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/gdb-pretty-struct-and-enums.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-functions-nested.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-method-on-generic-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-static-method-on-struct-and-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-struct-style-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/generic-tuple-style-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/issue-13213.rs: [missing] -> ignore (ignored when the debugger is cdb (Fails with exit code 0xc0000135 ("the application failed to initialize properly"))) (J0)
  • [debuginfo-cdb] tests/debuginfo/issue-22656.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/issue-57822.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-for-loop.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-if.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-parameterless-closure.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-stack-closure.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-unconditional-loop.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scope-in-while.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/lexical-scopes-in-block-expression.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/marker-types.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/method-on-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/method-on-generic-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/method-on-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/method-on-trait.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/method-on-tuple-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/msvc-pretty-enums.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/multi-cgu.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/multiline-calls.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/multiple-functions-equal-var-names.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/mutable-locs.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/mutex.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/name-shadowing-and-scope-nesting.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/opt/dead_refs.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/pretty-huge-vec.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/pretty-slices.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/rc_arc.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/recursive-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/reference-debuginfo.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/regression-bad-location-list-67992.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/rwlock-write.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/self-in-generic-default-method.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/should-fail.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/simd.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/simple-lexical-scope.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/simple-tuple.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/skip_second_statement.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/strings-and-strs.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/struct-in-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/struct-in-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/struct-namespace.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/struct-style-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/thread-names.rs#macos: [missing] -> ignore (only executed when the operating system is macos) (J0)
  • [debuginfo-cdb] tests/debuginfo/thread-names.rs#win: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/thread.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/trait-pointers.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/tuple-in-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/tuple-struct.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/tuple-style-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/unique-enum.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/unit-type.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/unreachable-locals.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/var-captured-in-sendable-closure.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/var-captured-in-stack-closure.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/vec-slices.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/zst-interferes-with-prologue.rs: [missing] -> pass (J0)
  • [debuginfo-cdb] tests/debuginfo/numeric-types.rs: [missing] -> pass (J1)

(and 73 additional test diffs)

Additionally, 96 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f889772d6500faebcac5bb70fa44b5e6581c38cd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 1h 52m -> 2h 8m (+14.9%)
  2. aarch64-gnu-llvm-20-2: 48m 48s -> 54m 52s (+12.4%)
  3. dist-apple-various: 1h -> 1h 7m (+12.1%)
  4. dist-aarch64-msvc: 1h 43m -> 1h 31m (-11.6%)
  5. x86_64-msvc-ext2: 1h 44m -> 1h 33m (-10.8%)
  6. dist-x86_64-msvc-alt: 2h 46m -> 2h 28m (-10.6%)
  7. dist-powerpc64-linux-musl: 1h 31m -> 1h 40m (+10.0%)
  8. x86_64-gnu-nopt: 2h 23m -> 2h 9m (-9.8%)
  9. i686-gnu-nopt-2: 2h 17m -> 2h 4m (-9.1%)
  10. dist-aarch64-llvm-mingw: 1h 51m -> 1h 42m (-8.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f889772): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.2%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.0%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.3% [5.3%, 5.3%] 1
Regressions ❌
(secondary)
2.9% [1.6%, 4.2%] 2
Improvements ✅
(primary)
-2.6% [-4.6%, -0.7%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-4.6%, 5.3%] 3

Cycles

Results (secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.3% [5.0%, 5.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.2%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.5%, -0.0%] 43
Improvements ✅
(secondary)
-0.4% [-1.5%, -0.0%] 44
All ❌✅ (primary) -0.2% [-0.5%, -0.0%] 43

Bootstrap: 474.029s -> 472.84s (-0.25%)
Artifact size: 397.93 MiB -> 397.96 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants