rustdoc: Render Sized? on traits and generics#19272
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 27, 2014
Merged
Conversation
Both `trait Foo for Sized?` and `<Sized? T>` are handled correctly. Fix rust-lang#18515
Contributor
Author
|
(This PR is rebased on #19174 and not master) |
Contributor
Author
|
Rendered docs here: http://homer.crystae.net/19272/doc/std/cmp/trait.PartialOrd.html That page should have uses of |
Member
|
Awesome, thanks @tomjakubowski! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 24, 2014
At the same time remove the `pub use` of the variants in favor of accessing through the enum type itself. This is a breaking change as the `Found` and `NotFound` variants must now be imported through `BinarySearchResult` instead of just `std::slice`. [breaking-change] Closes rust-lang#19272
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
Both `trait Foo for Sized?` and `<Sized? T>` are handled correctly. Fix rust-lang#18515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
trait Foo for Sized?and<Sized? T>are handled correctly.Fix #18515