Merged
Conversation
- unbreak the build under openbsd - while here, apply same modification to dragonfly, freebsd, ios (pid_t imported, but not used in raw.rs)
First, a link was broken. Second, the wording was a bit unclear, so I fixed it up. Fixes rust-lang#24852
These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
The variable doesn't need to be mutable.
Even spelled out, one would say 'a Universal Character Set'
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors-servo: r+ p=20 |
Collaborator
|
📌 Commit 3334bd0 has been approved by |
Contributor
|
@Manishearth: wrong bors :P though I guess it doesn't care what name. |
Member
Author
|
Yeah :) |
Collaborator
|
⌛ Testing commit 3334bd0 with merge fe09710... |
Collaborator
|
💔 Test failed - auto-mac-64-opt |
Member
Author
|
@bors: r+ force |
Collaborator
|
📌 Commit ac12fc8 has been approved by |
Collaborator
|
⌛ Testing commit ac12fc8 with merge 5cdfbca... |
Collaborator
|
💔 Test failed - auto-mac-64-opt |
Collaborator
|
📌 Commit ac6091d has been approved by |
Collaborator
|
⌛ Testing commit ac6091d with merge dceb125... |
Member
Author
|
@bors: r+ force |
Collaborator
|
📌 Commit ac6091d has been approved by |
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
|
⌛ Testing commit ac6091d with merge 57cb132... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
…lexcrichton Hi! While researching stuff for the reference and the grammar, I came across a few mentions of using the `priv` keyword that was removed in 0.11.0 (rust-lang#13547, rust-lang#8122, rust-lang/rfcs#26, [RFC 0026](https://github.com/rust-lang/rfcs/blob/master/text/0026-remove-priv.md)). One occurrence is a mention in the reference, a few are in comments, and a few are marking test functions. I left the test that makes sure you can't name an ident `priv` since it's still a reserved keyword. I did a little grepping around for `priv `, priv in backticks, `Private` etc and I think the remaining instances are fine, but if anyone knows anywhere in particular I should check for any other lingering mentions of `priv`, please let me know and I would be happy to! 🍂 🌊
…r=steveklabnik Fix incorrect link tag formatting in `doc/trpl/nightly-rust.md`. Notice the last word of the paragraph. Before:  After: 
- unbreak the build under openbsd - while here, apply same modification to dragonfly, freebsd, ios (pid_t imported, but not used in raw.rs) r? @alexcrichton cc @wg @mneumann @vhbit
First, a link was broken. Second, the wording was a bit unclear, so I fixed it up. Fixes rust-lang#24852
…ichton These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
The variable doesn't need to be mutable.
Even spelled out, one would say 'a Universal Character Set'
Member
Author
|
@bors: r+ force |
Collaborator
|
📌 Commit 616b94b has been approved by |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
priv#24981, fix incorrect link tag in doc/trpl/nightly-rust.md #24982, Fixed iOS build #24983, Add test for #15919 #24987, remove denied unused import: pid_t in raw #24988, Fix two issues with TRPL: unsized types #24991, Describe (a,) vs (a) in docs #24992, Fix code sample, remove unstable code #24994, Fix broken links in the book. #24998, Clarify intention wrt integers #25002, Mark the {min,max}_value functions on integers #[inline]. #25010, Remove unnecessary 'mut' qualifier on doc-comment var #25014, doc: current_dir returns a PathBuf, not a Path #25020, Replaces instanced of 'an UTF' with 'a UTF' #25021