Conversation
Member
|
@bors: r+ nice, thanks! |
Collaborator
|
📌 Commit 4a85015 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 17, 2015
Like nrc@d21bfff, but for the type grammar. r? @nrc
Collaborator
Collaborator
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 20, 2017
Fix regression in parsing of trait object types Fixes rust-lang#39169 Accepting parens in this position is a regression itself, introduced in Rust 1.6 by rust-lang#29870, so I hope to revert this in my next bounds refactoring patch (possibly with a warning, crater run, etc). r? @eddyb
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like nrc@d21bfff, but for the type grammar.
r? @nrc