Clarify scenario where AsciiExt appears to operate on non-ASCII#31401
Clarify scenario where AsciiExt appears to operate on non-ASCII#31401bors merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
c33a59d to
8dd1dc1
Compare
src/libstd/ascii.rs
Outdated
There was a problem hiding this comment.
Showing the imports is considered better nowadays.
|
Thanks so much! A few nits, and also, could you wrap this to 80 cols, not 100? |
8dd1dc1 to
93d6425
Compare
|
Comments have been addressed |
|
@bors: r+ rollup thanks so much |
|
📌 Commit 93d6425 has been approved by |
Fixes #31203