Removed integer suffixes in libsyntax crate#32179
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 13, 2016
srinivasreddy:remove_int_suffix
Merged
Removed integer suffixes in libsyntax crate#32179bors merged 1 commit intorust-lang:masterfrom srinivasreddy:remove_int_suffix
bors merged 1 commit intorust-lang:masterfrom
srinivasreddy:remove_int_suffix
Conversation
Contributor
Author
|
@steveklabnik pls take a look. I intended to do clean up per crate. I hope that is Ok, rather than one gigantic PR. what say? |
Contributor
|
@bors: r+ rollup Per crate is fine, it's easy to roll them up 😄 |
Collaborator
|
📌 Commit bf50bd4 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 11, 2016
…steveklabnik Removed integer suffixes in libsyntax crate
src/libsyntax/errors/emitter.rs
Outdated
| type BOOL = i32; | ||
| type HANDLE = *mut u8; | ||
| const STD_ERROR_HANDLE: DWORD = -12i32 as DWORD; | ||
| const STD_ERROR_HANDLE: DWORD = -12 as DWORD; |
Member
There was a problem hiding this comment.
This suffix is necessary since DWORD is unsigned on windows. (or, I think that's the reason)
cc @retep998
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3376/steps/compile/logs/stdio
Contributor
There was a problem hiding this comment.
Yep, DWORD is u32 so the type has to be specified as i32 in order to specify a negative value and then cast to DWORD.
Contributor
Author
There was a problem hiding this comment.
Member
|
@bors r=steveklabnik |
Collaborator
|
📌 Commit b308ed0 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 12, 2016
…steveklabnik Removed integer suffixes in libsyntax crate
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 13, 2016
…steveklabnik Removed integer suffixes in libsyntax crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.