Skip to content

Book: Fix phrasing: “an associated type” → “an object with an associated type”.#32618

Merged
bors merged 1 commit intorust-lang:masterfrom
progval:patch-1
Mar 31, 2016
Merged

Book: Fix phrasing: “an associated type” → “an object with an associated type”.#32618
bors merged 1 commit intorust-lang:masterfrom
progval:patch-1

Conversation

@progval
Copy link
Contributor

@progval progval commented Mar 30, 2016

From what I understood, graph is the object from which we create a trait object, and the associated types are Graph::N and Graph::E.

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 30, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

apasel422
apasel422 reviewed Mar 30, 2016
View reviewed changes
src/doc/book/associated-types.md Outdated
Copy link
Contributor

@apasel422 apasel422 Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that "from a trait with an associated type" is somewhat more accurate.

Copy link
Contributor

@steveklabnik steveklabnik Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Contributor Author

@progval progval Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@progval progval force-pushed the patch-1 branch 2 times, most recently from bfa1e6b to b1b3738 Compare March 30, 2016 17:35
@steveklabnik
Copy link
Contributor

steveklabnik commented Mar 30, 2016

@bors: r+ rollup

thank you!

@bors
Copy link
Collaborator

bors commented Mar 30, 2016

📌 Commit b1b3738 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 30, 2016
@Manishearth
Rollup merge of rust-lang#32618 - ProgVal:patch-1, r=steveklabnik
458fae7 
Book: Fix phrasing: “an associated type” → “an object with an associated type”.

From what I understood, `graph` is the object from which we create a trait object, and the associated types are `Graph::N` and `Graph::E`.
@Manishearth Manishearth mentioned this pull request Mar 30, 2016
Merged
bors added a commit that referenced this pull request Mar 30, 2016
@bors
Auto merge of #32628 - Manishearth:rollup, r=Manishearth
30a3849 
Rollup of 4 pull requests

- Successful merges: #32259, #32494, #32612, #32618
- Failed merges: #32562
@bors bors merged commit b1b3738 into rust-lang:master Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@progval @rust-highfive @steveklabnik @bors @apasel422