Skip to content

Update E0102's example (fixes #33057)#33058

Merged
bors merged 1 commit intorust-lang:masterfrom
Manishearth:fx-E0102
Apr 19, 2016
Merged

Update E0102's example (fixes #33057)#33058
bors merged 1 commit intorust-lang:masterfrom
Manishearth:fx-E0102

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 17, 2016 •
edited
Loading

@Manishearth
Copy link
Member Author

Manishearth commented Apr 17, 2016

@bors delegate=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Apr 17, 2016

✌️ @GuillaumeGomez can now approve this pull request

GuillaumeGomez
GuillaumeGomez reviewed Apr 17, 2016
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Apr 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust flag isn't needed in this case as far as I know. If no option is passed, the code is compiled and run.

Copy link
Member Author

@Manishearth Manishearth Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like to be explicit about this.

Copy link
Member

@GuillaumeGomez GuillaumeGomez Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep it, it'll be the only place where such a flag is used. Also, by default, it is rust code. We only precise it when it's not.

Copy link
Member Author

@Manishearth Manishearth Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 17, 2016 •
edited
Loading

Except for the nit (not really one but I like to remain consistent with the other error codes examples), it's all good. Thanks!

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 17, 2016

Fixes #33057.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 18, 2016

@bors: rollup

@Manishearth
Copy link
Member Author

Manishearth commented Apr 18, 2016

@bors r=GuillaumeGomez rollup

@GuillaumeGomez you need to have r+ somewhere in the command

@bors
Copy link
Collaborator

bors commented Apr 18, 2016

📌 Commit f089cf9 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Apr 18, 2016

⌛ Testing commit f089cf9 with merge 7893b46...

@bors
Copy link
Collaborator

bors commented Apr 18, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Apr 18, 2016

@bors: retry

On Mon, Apr 18, 2016 at 9:53 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/752

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33058 (comment)

@steveklabnik steveklabnik mentioned this pull request Apr 18, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 18, 2016
@steveklabnik
Rollup merge of rust-lang#33058 - Manishearth:fx-E0102, r=GuillaumeGomez
ec44ddc 
Update E0102's example (fixes rust-lang#33057)

r? @GuillaumeGomez
bors added a commit that referenced this pull request Apr 18, 2016
@bors
Auto merge of #33081 - steveklabnik:rollup, r=steveklabnik
b324fa7 
Rollup of 6 pull requests

- Successful merges: #32558, #32906, #33007, #33008, #33035, #33058
- Failed merges: #32912
@bors bors merged commit f089cf9 into rust-lang:master Apr 19, 2016
@Manishearth Manishearth deleted the fx-E0102 branch December 2, 2016 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Manishearth @bors @GuillaumeGomez @alexcrichton