rustc: Handle concurrent `create_dir` requests#33332

alexcrichton · 2016-05-02T05:34:20Z

The compiler created a directory as part of -Z incremental but that may be
hierarchically used concurrently so we need to protect ourselves against that.

rust-highfive · 2016-05-02T05:34:31Z

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2016-05-02T05:34:52Z

r? @michaelwoerister

michaelwoerister · 2016-05-02T06:14:17Z

src/librustc_incremental/persist/util.rs

When do you get ErrorKind::NotFound? If the parent doesn't exist?

Yeah that's the case where this is emulating create_dir_all instead of just create_dir, and if you create /foo/bar/baz but /foo/bar doesn't exist you'll get EEXIST (not found)

michaelwoerister · 2016-05-02T16:35:54Z

lgtm, r=me when it's compile clean.

The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.

alexcrichton · 2016-05-02T16:38:18Z

@bors: r=michaelwoerister 71e6329

…ichaelwoerister rustc: Handle concurrent `create_dir` requests The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.

Rollup of 14 pull requests - Successful merges: #32756, #33129, #33225, #33260, #33309, #33320, #33323, #33324, #33325, #33330, #33332, #33334, #33335, #33346 - Failed merges:

…ichaelwoerister rustc: Handle concurrent `create_dir` requests The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.

Rollup of 14 pull requests - Successful merges: #32756, #33129, #33225, #33260, #33309, #33320, #33323, #33324, #33325, #33330, #33332, #33334, #33335, #33346 - Failed merges:

rust-highfive assigned Aatch May 2, 2016

alexcrichton mentioned this pull request May 2, 2016

resolve: improve diagnostics and lay groundwork for resolving before ast->hir #33190

Merged

rust-highfive assigned michaelwoerister and unassigned Aatch May 2, 2016

michaelwoerister reviewed May 2, 2016
View reviewed changes

rustc: Handle concurrent create_dir requests

71e6329

The compiler created a directory as part of `-Z incremental` but that may be hierarchically used concurrently so we need to protect ourselves against that.

alexcrichton force-pushed the handle-more-races branch from b0be4d4 to 71e6329 Compare May 2, 2016 16:38

Manishearth mentioned this pull request May 2, 2016

Rollup of 14 pull requests #33354

Merged

bors merged commit 71e6329 into rust-lang:master May 3, 2016

alexcrichton deleted the handle-more-races branch May 12, 2016 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustc: Handle concurrent `create_dir` requests#33332