syntax_ext: format: nest_level's are no more#33666
Merged
bors merged 2 commits intorust-lang:masterfrom May 18, 2016
Merged
Conversation
`nest_level` is long dead since cac7a20 (PR rust-lang#14831), so is `check_positional_ok()`. Let's bid them farewell.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
src/libsyntax_ext/format.rs
Outdated
| @@ -68,7 +68,6 @@ struct Context<'a, 'b:'a> { | |||
| name_positions: HashMap<String, usize>, | |||
|
|
|||
| /// Updated as arguments are consumed or methods are entered | |||
Contributor
There was a problem hiding this comment.
Should delete the comment too.
Contributor
Author
There was a problem hiding this comment.
Oops, sure. Note that next_arg is still used for verifying types for implicit positional args, so I'll only delete the reference to methods.
Contributor
Author
There was a problem hiding this comment.
Done, should I squash my commits or will it be merged as such?
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 2ea6c70 has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 17, 2016
…tsakis syntax_ext: format: nest_level's are no more Just noticed this while working on rust-lang#33642 and here's a quick fix, shouldn't touch anything else. It's some historic code indeed...
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 18, 2016
…tsakis syntax_ext: format: nest_level's are no more Just noticed this while working on rust-lang#33642 and here's a quick fix, shouldn't touch anything else. It's some historic code indeed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed this while working on #33642 and here's a quick fix, shouldn't touch anything else. It's some historic code indeed...