resolve: record pattern def when `resolve_pattern` returns `Err(true)`#33967

dsprenkels · 2016-05-30T16:33:29Z

I propose a fix for issue #33293.

In 1a374b8, (pr #33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that record_def was called in all cases, which lead to an ICE in [1].
This change restores the original else case, but keeps the changes that were committed in 1a374b8.

[1] rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_

…h` returns `Err(true)` In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. This commit fixes issue rust-lang#33293. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`

rust-highfive · 2016-05-30T16:33:36Z

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

dsprenkels · 2016-05-30T16:43:01Z

N.b. I think that a test case should be added to this PR. This gist shows a suitable piece of code.
But I don't know how to tell the test system that this test case should report

failed to resolve. Use of undeclared type or module `aaa` [E0433]

and the the same time not report:

internal compiler error: ../src/librustc/middle/mem_categorization.rs:1271: enum pattern didn't resolve to enum or struct None

dsprenkels · 2016-05-31T14:12:56Z

r? @Manishearth

petrochenkov · 2016-05-31T14:26:54Z

LGTM.
(I'm doing some larger changes in this area, which include this change, but it's ok to land this in the meantime)

Manishearth · 2016-06-01T06:55:57Z

@bors r=petrochenkov

bors · 2016-06-01T06:55:58Z

📌 Commit cde0f94 has been approved by petrochenkov

…, r=petrochenkov resolve: record pattern def when `resolve_pattern` returns `Err(true)` I propose a fix for issue rust-lang#33293. In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`

Rollup of 11 pull requests - Successful merges: #33385, #33606, #33841, #33892, #33896, #33915, #33921, #33967, #33970, #33973, #33977 - Failed merges:

rust-highfive assigned jroesch May 30, 2016

dsprenkels changed the title ~~librustc_resolve: record pattern def when resolve_pattern returns Err(true)~~ resolve: record pattern def when resolve_pattern returns Err(true) May 30, 2016

rust-highfive assigned Manishearth and unassigned jroesch May 31, 2016

Manishearth mentioned this pull request Jun 1, 2016

Rollup of 11 pull requests #34004

Merged

bors added a commit that referenced this pull request Jun 1, 2016

Auto merge of #34004 - Manishearth:rollup, r=Manishearth

806a553

Rollup of 11 pull requests - Successful merges: #33385, #33606, #33841, #33892, #33896, #33915, #33921, #33967, #33970, #33973, #33977 - Failed merges:

bors merged commit cde0f94 into rust-lang:master Jun 1, 2016

dsprenkels mentioned this pull request Jun 1, 2016

ICE: "enum pattern didn't resolve to enum or struct None" #33293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

resolve: record pattern def when `resolve_pattern` returns `Err(true)`#33967