Support nested cfg_attr attributes#34216
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 16, 2016
Merged
Conversation
Member
|
cc @cgswords |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 65d256e has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 16, 2016
Support nested `cfg_attr` attributes
Support arbitrarily deeply nested `cfg_attr` attributes (e.g. `#[cfg_attr(foo, cfg_attr(bar, baz))]`).
This makes configuration idempotent.
Currently, the nighties do not support any `cfg_attr` nesting. Stable and beta support just one level of `cfg_attr` nesting (expect for attributes on macro-expanded nodes, where no nesting is supported).
This is a [breaking-change]. For example, the following would break:
```rust
macro_rules! m { () => {
#[cfg_attr(all(), cfg_attr(all(), cfg(foo)))]
fn f() {}
} }
m!();
fn main() { f() } //~ ERROR unresolved name `f`
```
r? @nrc
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support arbitrarily deeply nested
cfg_attrattributes (e.g.#[cfg_attr(foo, cfg_attr(bar, baz))]).This makes configuration idempotent.
Currently, the nighties do not support any
cfg_attrnesting. Stable and beta support just one level ofcfg_attrnesting (expect for attributes on macro-expanded nodes, where no nesting is supported).This is a [breaking-change]. For example, the following would break:
r? @nrc