Add example for `std::thread::sleep`.#34406

frewsxcv · 2016-06-22T01:41:29Z

No description provided.

frewsxcv · 2016-06-22T01:52:05Z

r? @steveklabnik

GuillaumeGomez · 2016-06-22T09:55:23Z

Thanks!

@bors: r+ rollup

bors · 2016-06-22T09:55:24Z

📌 Commit 0183f7f has been approved by GuillaumeGomez

bors · 2016-06-22T16:43:43Z

⌛ Testing commit 0183f7f with merge 56854cb...

bors · 2016-06-22T16:50:47Z

💔 Test failed - auto-linux-cross-opt

alexcrichton · 2016-06-22T17:55:48Z

@bors: retry

On Wed, Jun 22, 2016 at 9:50 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-cross-opt
http://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/2712

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95EKdV2h3Yd5J6W3Fle1JqhDC5VPYks5qOWfqgaJpZM4I7VKV
.

bors · 2016-06-22T19:14:05Z

⌛ Testing commit 0183f7f with merge 31b6756...

bors · 2016-06-22T20:35:11Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

frewsxcv · 2016-06-22T20:37:14Z

failures:

---- thread::sleep_0 stdout ----
    thread 'thread::sleep_0' panicked at 'test executable failed:

thread 'main' panicked at 'assertion failed: now.elapsed() > ten_millis', <anon>:11
note: Run with `RUST_BACKTRACE=1` for a backtrace.
', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\librustdoc\test.rs:327
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Failure looks legit. But why?

GuillaumeGomez · 2016-06-22T21:07:10Z

Good question. I tested it locally and it worked just fine.

GuillaumeGomez · 2016-06-22T21:07:40Z

Maybe ">=" instead of ">"?

frewsxcv · 2016-06-23T01:27:19Z

Updated to >=.

GuillaumeGomez · 2016-06-23T10:33:53Z

@bors: r+ rollup

bors · 2016-06-23T10:33:54Z

📌 Commit bbc33ac has been approved by GuillaumeGomez

bors · 2016-06-23T23:05:27Z

⌛ Testing commit bbc33ac with merge f33dd35...

bors · 2016-06-23T23:11:29Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2016-06-23T23:31:10Z

@bors: retry

On Thu, Jun 23, 2016 at 4:11 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/9568

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95EffpUfsAAPURFcyjqZYWPc4qQjzks5qOxKlgaJpZM4I7VKV
.

Manishearth · 2016-06-25T12:45:41Z

http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1554

frewsxcv · 2016-06-25T12:47:41Z

Is there a Windows bug with std::thread::sleep?

Rollup of 8 pull requests - Successful merges: #34379, #34406, #34411, #34414, #34435, #34438, #34445, #34449 - Failed merges:

Add example for `std::thread::sleep`. None

bors · 2016-06-25T18:03:05Z

⌛ Testing commit bbc33ac with merge cd0b94a...

bors · 2016-06-25T20:01:30Z

💔 Test failed - auto-win-msvc-64-opt

Add example for `std::thread::sleep`. None

alexcrichton · 2016-06-27T16:27:24Z

We've discussed this a few times before, but could tests that purposefully block for a long time be tagged with no_run? It seems bad to forcefully cause the test suite to take longer :(

frewsxcv · 2016-06-27T16:30:45Z

@alexcrichton Sure, I can do that, but should there be any concern about the test failing on the Windows builders?

alexcrichton · 2016-06-27T16:37:18Z

Nah it's probably just spurious. Most assertions about intervals slept or things like that end up failing eventually. Time's weird.

frewsxcv · 2016-06-27T17:06:31Z

Updated to use no_run.

alexcrichton · 2016-06-27T17:09:26Z

@bors: r+ a7b9e54

Add example for `std::thread::sleep`. None

Rollup of 13 pull requests - Successful merges: #34080, #34287, #34328, #34406, #34415, #34442, #34462, #34471, #34475, #34479, #34517, #34518, #34524 - Failed merges: #33951

rust-highfive assigned steveklabnik Jun 22, 2016

frewsxcv force-pushed the sleep-ex branch from 0183f7f to bbc33ac Compare June 23, 2016 01:27

Manishearth mentioned this pull request Jun 25, 2016

Rollup of 8 pull requests #34464

Merged

bors added a commit that referenced this pull request Jun 25, 2016

Auto merge of #34464 - Manishearth:rollup, r=Manishearth

b8214dc

Rollup of 8 pull requests - Successful merges: #34379, #34406, #34411, #34414, #34435, #34438, #34445, #34449 - Failed merges:

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 25, 2016

Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=GuillaumeGomez

dfbf619

Add example for `std::thread::sleep`. None

GuillaumeGomez mentioned this pull request Jun 25, 2016

Rollup of 11 pull requests #34470

Closed

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016

Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=GuillaumeGomez

330fa40

Add example for `std::thread::sleep`. None

steveklabnik mentioned this pull request Jun 27, 2016

Rollup of 9 pull requests #34500

Closed

Add example for std::thread::sleep.

a7b9e54

frewsxcv force-pushed the sleep-ex branch from bbc33ac to a7b9e54 Compare June 27, 2016 17:06

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016

Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=alexcrichton

71a97c0

Add example for `std::thread::sleep`. None

steveklabnik mentioned this pull request Jun 27, 2016

Rollup of 11 pull requests #34508

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 28, 2016

Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=alexcrichton

5d6b41f

Add example for `std::thread::sleep`. None

GuillaumeGomez mentioned this pull request Jun 28, 2016

Rollup of 13 pull requests #34525

Merged

bors merged commit a7b9e54 into rust-lang:master Jun 28, 2016

frewsxcv deleted the sleep-ex branch October 2, 2016 23:06

Uh oh!

Conversation

frewsxcv commented Jun 22, 2016

Uh oh!

frewsxcv commented Jun 22, 2016

Uh oh!

GuillaumeGomez commented Jun 22, 2016

Uh oh!

bors commented Jun 22, 2016

Uh oh!

bors commented Jun 22, 2016

Uh oh!

bors commented Jun 22, 2016

Uh oh!

alexcrichton commented Jun 22, 2016

Uh oh!

bors commented Jun 22, 2016

Uh oh!

bors commented Jun 22, 2016

Uh oh!

frewsxcv commented Jun 22, 2016

Uh oh!

GuillaumeGomez commented Jun 22, 2016

Uh oh!

GuillaumeGomez commented Jun 22, 2016

Uh oh!

frewsxcv commented Jun 23, 2016

Uh oh!

GuillaumeGomez commented Jun 23, 2016

Uh oh!

bors commented Jun 23, 2016

Uh oh!

bors commented Jun 23, 2016

Uh oh!

bors commented Jun 23, 2016

Uh oh!

alexcrichton commented Jun 23, 2016

Uh oh!

Manishearth commented Jun 25, 2016

Uh oh!

frewsxcv commented Jun 25, 2016

Uh oh!

bors commented Jun 25, 2016

Uh oh!

bors commented Jun 25, 2016

Uh oh!

alexcrichton commented Jun 27, 2016

Uh oh!

frewsxcv commented Jun 27, 2016

Uh oh!

alexcrichton commented Jun 27, 2016

Uh oh!

frewsxcv commented Jun 27, 2016

Uh oh!

alexcrichton commented Jun 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants