doc: make the conditional-compilation example work#34610
doc: make the conditional-compilation example work#34610bors merged 3 commits intorust-lang:masterfrom wuranbo:patch-2
Conversation
If not, the error `does not have these features: foo` confused. r? @steveklabnik
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| default = [] | ||
|
|
||
| # Add feature "foo" here, then you can use it. | ||
| # Our "foo" feature depends on nothings else. |
There was a problem hiding this comment.
Can you change this to "nothing" rather than "nothings" please?
There was a problem hiding this comment.
OK~My english is poor.
There was a problem hiding this comment.
No worries! 😄 I'm a native speaker and mine is often terrible.
|
Thanks @wuranbo ! Just a few nits. |
|
@bors: r+ rollup thank you! |
|
📌 Commit d30662f has been approved by |
doc: make the conditional-compilation example work If not, the error `does not have these features: foo` confused. r? @steveklabnik
doc: make the conditional-compilation example work If not, the error `does not have these features: foo` confused. r? @steveklabnik
4 participants
If not, the error
does not have these features: fooconfused.r? @steveklabnik