Skip to content

Update on struct expressions#34742

Merged
bors merged 1 commit intorust-lang:masterfrom
abhijeetbhagat:master
Jul 12, 2016
Merged

Update on struct expressions#34742
bors merged 1 commit intorust-lang:masterfrom
abhijeetbhagat:master

Conversation

@abhijeetbhagat
Copy link
Contributor

@abhijeetbhagat abhijeetbhagat commented Jul 9, 2016

Update doc for struct expressions (#32769)

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 9, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

steveklabnik commented Jul 10, 2016

@bors: r+ rollup

Thanks so much!

@bors
Copy link
Collaborator

bors commented Jul 10, 2016

📌 Commit f396cb4 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Jul 11, 2016

⌛ Testing commit f396cb4 with merge f684f5b...

bors added a commit that referenced this pull request Jul 11, 2016
@bors
Auto merge of #34742 - abhijeetbhagat:master, r=steveklabnik
f684f5b 
Update on struct expressions

Update doc for struct expressions (#32769)
@bors
Copy link
Collaborator

bors commented Jul 11, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Jul 11, 2016

@bors: retry

hmm... weird!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 12, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 12, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34742 - abhijeetbhagat:master, r=steveklabnik
e2e4b82 
Update on struct expressions

Update doc for struct expressions (rust-lang#32769)
bors added a commit that referenced this pull request Jul 12, 2016
@bors
Auto merge of #34778 - GuillaumeGomez:rollup, r=GuillaumeGomez
31e9ed5 
Rollup of 7 pull requests

- Successful merges: #34736, #34737, #34740, #34742, #34749, #34750, #34770
- Failed merges: #33951
@bors bors merged commit f396cb4 into rust-lang:master Jul 12, 2016
@apasel422 apasel422 mentioned this pull request Sep 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhijeetbhagat @rust-highfive @steveklabnik @bors @alexcrichton