Mention where std::vec structs originate from.#34818
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 15, 2016
Merged
Conversation
Contributor
Author
Member
|
Thanks! @bors: r+ rollup |
Collaborator
|
📌 Commit 528de81 has been approved by |
Contributor
|
This patch causes a link check failure, see #34819. Excerpt from the log: |
Contributor
Author
|
Fixed in the latest force push. diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs
index f6861c0..b51b971 100644
--- a/src/libcollections/vec.rs
+++ b/src/libcollections/vec.rs
@@ -1604,8 +1604,8 @@ impl<'a, T> FromIterator<T> for Cow<'a, [T]> where T: Clone {
/// An iterator that moves out of a vector.
///
-/// This `struct` is created by the `into_iter` method on [`Vec`] (provided by
-/// the [`IntoIterator`] trait).
+/// This `struct` is created by the `into_iter` method on [`Vec`][`Vec`] (provided
+/// by the [`IntoIterator`] trait).
///
/// [`Vec`]: struct.Vec.html
/// [`IntoIterator`]: ../iter/trait.IntoIterator.html |
src/libcollections/vec.rs
Outdated
Contributor
There was a problem hiding this comment.
You'll need to change this to ../../std/iter/trait.IntoIterator.html so the link works from the collections docs as well.
Contributor
Author
There was a problem hiding this comment.
Good call, didn't think about the collection docs getting generated. Will force push shortly.
Contributor
Author
There was a problem hiding this comment.
Latest force push includes this change.
Member
|
@bors: r+ rollup |
Collaborator
|
📌 Commit cf21a7b has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 15, 2016
Mention where `std::vec` structs originate from. None
bors
added a commit
that referenced
this pull request
Jul 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.