Skip to content

resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns#34963

Merged
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:useerr
Jul 28, 2016
Merged

resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns#34963
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:useerr

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jul 21, 2016

Closes #34933

r? @jseyfried

@jseyfried
Copy link
Contributor

jseyfried commented Jul 21, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2016

📌 Commit d7a968e has been approved by jseyfried

@bors
Copy link
Collaborator

bors commented Jul 24, 2016

⌛ Testing commit d7a968e with merge d7a0706...

@bors
Copy link
Collaborator

bors commented Jul 24, 2016

💔 Test failed - auto-win-msvc-64-opt

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Jul 24, 2016

Spurious failure.

@jseyfried
Copy link
Contributor

jseyfried commented Jul 25, 2016

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 25, 2016

⌛ Testing commit d7a968e with merge f8bf284...

@bors
Copy link
Collaborator

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Jul 25, 2016

@bors: retry

On Sun, Jul 24, 2016 at 10:51 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1926

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkvDBKUuN8VARarhgRx-JwQulFSks5qZE7TgaJpZM4JSGYt
.

@alexcrichton
Copy link
Member

alexcrichton commented Jul 25, 2016

@bors: retry

@bors
Copy link
Collaborator

bors commented Jul 25, 2016

⌛ Testing commit d7a968e with merge 3121221...

@bors
Copy link
Collaborator

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

alexcrichton commented Jul 25, 2016

@bors: retry

On Mon, Jul 25, 2016 at 3:06 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5072

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95MePtsnyvQ_ehZECRpdkEPOK6pjwks5qZTOCgaJpZM4JSGYt
.

@bors
Copy link
Collaborator

bors commented Jul 26, 2016

⌛ Testing commit d7a968e with merge 85ae467...

@bors
Copy link
Collaborator

bors commented Jul 26, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

alexcrichton commented Jul 26, 2016

@bors: retry

On Tue, Jul 26, 2016 at 3:31 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/5072

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95A6wUWoE-NciOX2dgWHswe0KSL3Cks5qZeIWgaJpZM4JSGYt
.

@jseyfried jseyfried mentioned this pull request Jul 26, 2016
Closed
@Manishearth Manishearth mentioned this pull request Jul 28, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 28, 2016
@Manishearth
Rollup merge of rust-lang#34963 - petrochenkov:useerr, r=jseyfried
43bcada 
resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns

Closes rust-lang#34933

r? @jseyfried
bors added a commit that referenced this pull request Jul 28, 2016
@bors
Auto merge of #35086 - Manishearth:rollup, r=Manishearth
748ecb1 
Rollup of 7 pull requests

- Successful merges: #34951, #34963, #34969, #35013, #35037, #35040, #35058
- Failed merges:
@bors bors merged commit d7a968e into rust-lang:master Jul 28, 2016
@petrochenkov petrochenkov deleted the useerr branch September 21, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov @jseyfried @bors @alexcrichton