Rename _ to {integer} and {float} for unknown numeric types#35080
Rename _ to {integer} and {float} for unknown numeric types#35080bors merged 2 commits intorust-lang:masterfrom
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
Keep in mind that integer and floating-point inference variables are different and sometimes it's helpful to tell them apart. |
|
@eddyb - agreed. I can change this to make that more explicit. Since being more explicit can also make types more cumbersome, I wanted to start simple. |
|
We could use {float} and {integer}... |
|
+1, this is a great change. I like having |
|
@nrc Small problem is with generics, e.g. |
sophiajt
force-pushed
the
fix_numeric_expected_found
branch
from
219aeea to
ea77049
Compare
|
r=me on the patch, do we want to solicit any more feedback? Or just run with it? (I'm happy either way) |
|
Should update the PR title and description to use |
sophiajt
changed the title
|
@eddyb - done |
|
This is awesome, such a small fix and such a fundamental improvement. Why haven't this been done years ago? |
|
@bors r+ |
|
📌 Commit ea77049 has been approved by |
|
@bors: rollup assuming this isn't very platform-specific and green travis means it's good to go whenever |
…d_found, r=nikomatsakis
Rename _ to {integer} and {float} for unknown numeric types
This PR renames _ to {integer} or {float} for unknown numeric types, to help people parse error messages that have numeric types that haven't been nailed down.
Example:
```rust
fn main() {
let x: String = 4;
}
```
Before:
```
error[E0308]: mismatched types
--> quicktest.rs:2:21
|
2 | let x: String = 4;
| ^ expected struct `std::string::String`, found integral variable
|
= note: expected type `std::string::String`
= note: found type `_`
error: aborting due to previous error
```
after:
```
error[E0308]: mismatched types
--> quicktest.rs:2:21
|
2 | let x: String = 4;
| ^ expected struct `std::string::String`, found integral variable
|
= note: expected type `std::string::String`
= note: found type `{integer}`
error: aborting due to previous error
```
```
…d_found, r=nikomatsakis
Rename _ to {integer} and {float} for unknown numeric types
This PR renames _ to {integer} or {float} for unknown numeric types, to help people parse error messages that have numeric types that haven't been nailed down.
Example:
```rust
fn main() {
let x: String = 4;
}
```
Before:
```
error[E0308]: mismatched types
--> quicktest.rs:2:21
|
2 | let x: String = 4;
| ^ expected struct `std::string::String`, found integral variable
|
= note: expected type `std::string::String`
= note: found type `_`
error: aborting due to previous error
```
after:
```
error[E0308]: mismatched types
--> quicktest.rs:2:21
|
2 | let x: String = 4;
| ^ expected struct `std::string::String`, found integral variable
|
= note: expected type `std::string::String`
= note: found type `{integer}`
error: aborting due to previous error
```
```
8 participants
This PR renames _ to {integer} or {float} for unknown numeric types, to help people parse error messages that have numeric types that haven't been nailed down.
Example:
Before:
after: