Change description of no-stack-check (#34915)#35156
Change description of no-stack-check (#34915)#35156abhijeetbhagat wants to merge 1 commit intorust-lang:masterfrom abhijeetbhagat:master
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @brson |
|
@abhijeetbhagat In addition to changing the help text as you've done here, can you also make it print that text as a warning, when the user passes it to the compiler? It looks to me like the right place to do it is somewhere in |
|
I am on it. |
|
☔ The latest upstream changes (presumably #35340) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing due to inactivity, but feel free to resubmit with a rebase! |
Marking the 'no-stack-check' codegen option as deprecated (Issue rust-lang#34915) Attempts to finish resolving issue rust-lang#34915. Based on pull request rust-lang#35156, which was closed due to inactivity.
Original issue : #34915
Change explanation: #35027