Conversation
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 1607d5b has been approved by |
Contributor
|
@bors r+ rollup |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit 1607d5b has been approved by |
| } | ||
| if let Some(ref mut span) = span { | ||
| span.lo = span.lo - BytePos(1); | ||
| span.hi = span.hi + BytePos(1); |
There was a problem hiding this comment.
Doesn't account for
fn f< T >() {}
^^^I decided to omit this manual span expansion in my implementation of this method. #35257
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 4, 2016
…thandturner E0132 update Fixes rust-lang#35258. r? @jonathandturner
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 4, 2016
…thandturner E0132 update Fixes rust-lang#35258. r? @jonathandturner
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 5, 2016
…thandturner E0132 update Fixes rust-lang#35258. r? @jonathandturner
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 5, 2016
…thandturner E0132 update Fixes rust-lang#35258. r? @jonathandturner
bors
added a commit
that referenced
this pull request
Aug 5, 2016
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35258.
r? @jonathandturner