Updated error format for E0069#35351

jaredwy · 2016-08-05T03:49:53Z

Fixes #35219 which is part of the error bonanza at #35233

rust-highfive · 2016-08-05T03:50:01Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sophiajt · 2016-08-05T14:03:14Z

src/test/compile-fail/E0069.rs

Thanks for PR - Looks good, but can you remove this extra line?

jaredwy · 2016-08-05T22:31:29Z

@jonathandturner let me know if you want me to rebase this.

sophiajt · 2016-08-05T22:34:03Z

@jaredwy - would you mind squashing the commits?

sophiajt · 2016-08-05T22:34:23Z

hehe, good call. yes, please :)

jaredwy · 2016-08-05T23:05:36Z

@jonathandturner hopefully good to go now.

sophiajt · 2016-08-05T23:16:36Z

Looks good!

@bors r+ rollup

bors · 2016-08-05T23:16:37Z

📌 Commit 1cf5142 has been approved by jonathandturner

…dturner Updated error format for E0069 Fixes rust-lang#35219 which is part of the error bonanza at rust-lang#35233 r? @jonathandturner

Rollup of 21 pull requests - Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394 - Failed merges: #35331, #35395

rust-highfive assigned sophiajt Aug 5, 2016

sophiajt reviewed Aug 5, 2016
View reviewed changes

src/test/compile-fail/E0069.rs Outdated

Copy link

Contributor

sophiajt Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR - Looks good, but can you remove this extra line?

Updated error format for E0069

1cf5142

jaredwy force-pushed the update-error-69 branch from a4ada33 to 1cf5142 Compare August 5, 2016 23:04

eddyb mentioned this pull request Aug 6, 2016

Rollup of 21 pull requests #35407

Merged

bors merged commit 1cf5142 into rust-lang:master Aug 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated error format for E0069#35351