Update E0033 to the new error format#35526
Conversation
|
Looks good. @bors r+ rollup |
|
📌 Commit 40b2e51 has been approved by |
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
|
@bors r- Looks like the test file may need another label. This might come from other PRs that have landed. Line 16 on the unit test needs one more NOTE: |
|
@jonathandturner looks like it comes from my other PR actually, because it doesn't show up in the unit tests of this branch rebased on master. I added the note |
|
Thanks. Let's see if that did it. @bors r+ rollup |
|
📌 Commit 80beeb3 has been approved by |
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
|
@bors r- fails tidy |
src/test/compile-fail/E0033.rs
Outdated
| //~^ ERROR E0038 | ||
| let &invalid = trait_obj; //~ ERROR E0033 | ||
| //~| method `foo` has no receiver | ||
| //~| NOTE the trait `SomeTrait` cannot be made into an object |
There was a problem hiding this comment.
Please move these to the left, indented under the erroring line, otherwise they're too wide (over 100 columns).
|
@eddyb just updated |
src/test/compile-fail/E0033.rs
Outdated
|
@eddyb just amended the previous commit |
| let trait_obj: &SomeTrait = SomeTrait; | ||
| //~^ ERROR E0425 | ||
| //~| ERROR E0038 | ||
| //~| method `foo` has no receiver |
There was a problem hiding this comment.
Does this actually work? I didn't think it worked without ERROR or NOTE.
|
@jonathandturner @eddyb the tests seem to work on my end, and looks like it passed on Travis. Please tell me about any errors that you see |
|
Well, I could find other tests using the same syntax, so it may just be something new (although I would've expected @jonathandturner to explain in that case. I believe it's the new error label). @bors r=jonathandturner |
|
📌 Commit a37e90a has been approved by |
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
Part of #35233
Addresses #35498
"r? @jonathandturner