E0072 update error format#35576

circuitfox · 2016-08-10T19:16:07Z

The bonus for this issue currently seems to be impossible to do reliably, as the compiler seems to lack span information for item names alone, like Foo in struct Foo { ... }. It would be possible to hack something together by computing span offsets, but that seems like a solution that would be begging for trouble.

A proper solution to this would, of course, be to add span information to the right place (seems to be rustc::hir::Item::name but I may be wrong).

rust-highfive · 2016-08-10T19:16:15Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sophiajt · 2016-08-10T20:55:40Z

Looks good!

@bors r+ rollup

bors · 2016-08-10T20:55:41Z

📌 Commit c5f9feb has been approved by jonathandturner

aravind-pg · 2016-08-10T23:27:54Z

src/librustc/traits/error_reporting.rs

        let mut err = struct_span_err!(self.sess, span, E0072,
                                       "recursive type `{}` has infinite size",
                                       self.item_path_str(type_def_id));
+        err.span_label(span, &format!("recursive type has infinite size"));


Seems like the call to format! is unnecessary?

it's not technically required here, though harmless.

…t, r=jonathandturner E0072 update error format Part of rust-lang#35233 Fixes rust-lang#35506 r? @jonathandturner The bonus for this issue currently seems to be impossible to do reliably, as the compiler seems to lack span information for item names alone, like `Foo` in `struct Foo { ... }`. It would be possible to hack something together by computing span offsets, but that seems like a solution that would be begging for trouble. A proper solution to this would, of course, be to add span information to the right place (seems to be `rustc::hir::Item::name` but I may be wrong).

Rollup of 23 pull requests - Successful merges: #35279, #35331, #35358, #35375, #35445, #35448, #35482, #35486, #35505, #35528, #35530, #35532, #35536, #35537, #35541, #35552, #35554, #35555, #35557, #35562, #35565, #35569, #35576 - Failed merges: #35395, #35415, #35563

E0072 update error format

c5f9feb

rust-highfive assigned sophiajt Aug 10, 2016

aravind-pg reviewed Aug 10, 2016
View reviewed changes

sophiajt mentioned this pull request Aug 11, 2016

Rollup of 23 pull requests #35592

Merged

bors merged commit c5f9feb into rust-lang:master Aug 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

E0072 update error format#35576