add -mrelax-relocations=no to i686-musl and i586-gnu#35577
add -mrelax-relocations=no to i686-musl and i586-gnu#35577bors merged 2 commits intorust-lang:masterfrom
Conversation
I've been experiencing rust-lang#34978 with these two targets. This applies the hack in rust-lang#35178 to these targets as well.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I think it's not necessary. We are already building musl with this flag for the i686-musl. For i586-gnu, I think we just use Ubuntu packages so we can't do anything there. |
|
Awesome, thanks for checking! |
|
@bors rollup |
add -mrelax-relocations=no to i686-musl and i586-gnu I've been experiencing rust-lang#34978 with these two targets. This applies the hack in rust-lang#35178 to these targets as well. r? @alexcrichton
add -mrelax-relocations=no to i686-musl and i586-gnu I've been experiencing rust-lang#34978 with these two targets. This applies the hack in rust-lang#35178 to these targets as well. r? @alexcrichton
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
5 participants
I've been experiencing #34978 with these two targets. This applies the
hack in #35178 to these targets as well.
r? @alexcrichton