Update error message for E0084#35804

pliniker · 2016-08-18T20:30:50Z

Fixes #35792 as part of #35233

rust-highfive · 2016-08-18T20:30:56Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sophiajt · 2016-08-18T20:32:05Z

Looks good!

@bors r+ rollup

bors · 2016-08-18T20:32:06Z

📌 Commit 161cb36 has been approved by jonathandturner

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

pliniker · 2016-08-19T01:09:54Z

@jonathandturner thanks for the blog post, following that made this a pleasant contribution experience!

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

sophiajt · 2016-08-19T22:59:31Z

@pliniker - great to hear!

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

Rollup of 19 pull requests - Successful merges: #35234, #35701, #35709, #35710, #35775, #35778, #35780, #35781, #35794, #35800, #35804, #35806, #35811, #35812, #35818, #35827, #35830, #35831, #35839 - Failed merges: #35759

Update error message for E0084

161cb36

rust-highfive assigned sophiajt Aug 18, 2016

pliniker closed this Aug 18, 2016

pliniker reopened this Aug 18, 2016

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 18, 2016

Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

9dea71e

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

steveklabnik mentioned this pull request Aug 18, 2016

Rollup of 11 pull requests #35808

Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016

Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

20b4b99

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

sophiajt mentioned this pull request Aug 19, 2016

Rollup of 13 pull requests #35826

Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016

Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

1136f42

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

sophiajt mentioned this pull request Aug 19, 2016

Rollup of 19 pull requests #35834

Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016

Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

5bcff96

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

sophiajt mentioned this pull request Aug 20, 2016

Rollup of 21 pull requests #35846

Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016

Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

15277eb

Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner

sophiajt mentioned this pull request Aug 20, 2016

Rollup of 19 pull requests #35857

Merged

bors merged commit 161cb36 into rust-lang:master Aug 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update error message for E0084#35804