Rustc metadata diagnostics#36102

GuillaumeGomez · 2016-08-29T14:29:56Z

r? @jonathandturner

GuillaumeGomez · 2016-08-29T14:31:15Z

This is a redoing from #34970.

sophiajt · 2016-08-29T17:22:25Z

src/librustc_metadata/diagnostics.rs

We could probably use a better example than "beer and tacos" ;)

You're hard on business. :-/

GuillaumeGomez · 2016-08-30T17:33:46Z

Beer became pimiento!

sophiajt · 2016-08-30T17:44:52Z

src/librustc_metadata/diagnostics.rs

Should this be get_pimientos?

GuillaumeGomez · 2016-08-30T21:19:39Z

Should be good now. :'(

sophiajt · 2016-08-30T21:45:43Z

@bors r+

bors · 2016-08-30T21:45:44Z

📌 Commit 354d596 has been approved by jonathandturner

bors · 2016-09-02T15:15:01Z

⌛ Testing commit 354d596 with merge 975f34a...

bors · 2016-09-02T15:20:00Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

GuillaumeGomez · 2016-09-02T15:41:04Z

@bors: retry

bors · 2016-09-02T15:43:53Z

⌛ Testing commit 354d596 with merge 9a4671f...

bors · 2016-09-02T15:55:38Z

💔 Test failed - auto-win-msvc-64-cargotest

alexcrichton · 2016-09-02T15:56:26Z

@bors: retry

On Fri, Sep 2, 2016 at 8:55 AM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1709

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36102 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95J0JTHiN1bzpEGQCoA1qIjwDqM9Jks5qmEb9gaJpZM4JviFk
.

bors · 2016-09-03T18:06:55Z

⌛ Testing commit 354d596 with merge 302462d...

bors · 2016-09-03T18:24:00Z

💔 Test failed - auto-linux-64-opt-rustbuild

TimNN · 2016-09-05T07:01:51Z

The problem is that this test passes on OS X (since the tests are apparently compiled as libraries, so no linking happens).

bors · 2016-09-05T16:55:23Z

💥 Test timed out

Rollup of 6 pull requests - Successful merges: #35845, #35983, #36065, #36102, #36242, #36245 - Failed merges:

…ostics, r=jonathandturner Rustc metadata diagnostics r? @jonathandturner

GuillaumeGomez · 2016-09-08T10:24:16Z

Once #36320 is merged, it'll be easier to see from where the problem comes.

TimNN · 2016-09-08T10:26:00Z

@GuillaumeGomez: have you seen my comment above?

GuillaumeGomez · 2016-09-08T11:39:35Z

@TimNN: Yes, however it can be the one which fails the tests since it isn't run.

EDIT: woups, my browser didn't go the correct line. Hum... This is problematic if we cannot check an error code. :-/

GuillaumeGomez · 2016-09-08T14:11:43Z

I have set the failing test into "ignore mode".

sophiajt · 2016-09-12T17:26:05Z

@GuillaumeGomez - please ignore the test only for OS X, if that's the troublesome platform:

// ignore-macos

TimNN · 2016-09-12T17:27:49Z

@jonathandturner: Is that possible outside of compiletest?

sophiajt · 2016-09-12T17:41:46Z

@TimNN - yeah it may not work outside of that. @alexcrichton mentioned it had limitations on irc.

sophiajt · 2016-09-12T17:42:46Z

If it doesn't support it in the part of code you're in, I guess it's fine to just ignore the whole thing.

GuillaumeGomez · 2016-09-12T18:47:59Z

I'll work on adding later on.

GuillaumeGomez · 2016-09-15T22:24:10Z

Any news?

sophiajt · 2016-09-16T16:34:40Z

@GuillaumeGomez - if you can't ignore just for the platform where you are in the code, I'm okay with ignoring the test.

GuillaumeGomez · 2016-09-16T22:06:46Z

rustdoc doesn't seem to provide such a thing but maybe I missed it?

cc @rust-lang/tools

TimNN · 2016-09-17T05:34:39Z

@GuillaumeGomez: I don't think rustdoc provides something like this either, so maybe the best solution is to ignore the test in the explain message and just add a test to compile-fail, where // ignore-macos can be used as far as I now.

(I just noticed that there is already a similar test for the compiler flag, linking to a Framework: https://github.com/rust-lang/rust/blob/master/src/test/compile-fail/manual-link-framework.rs).

Edit: There is even a test for this exact case: https://github.com/rust-lang/rust/blob/master/src/test/compile-fail/osx-frameworks.rs, so maybe that can just be updated to include the error code as well

GuillaumeGomez · 2016-09-17T11:13:02Z

It just fails without giving an error code. So I guess the better should be to keep it like this.

sophiajt · 2016-09-19T15:58:16Z

@bors r+

bors · 2016-09-19T15:58:32Z

📌 Commit d4c6a61 has been approved by jonathandturner

bors · 2016-09-19T20:23:12Z

⌛ Testing commit d4c6a61 with merge e054701...

…onathandturner Rustc metadata diagnostics r? @jonathandturner

bors · 2016-09-19T23:55:46Z

bors · 2016-09-19T23:55:46Z

…tics, r=<try> Rustc metadata diagnostics r? @jonathandturner

rust-highfive assigned sophiajt Aug 29, 2016

GuillaumeGomez force-pushed the rustc_metadata_diagnostics branch from e414eb5 to a425cb0 Compare August 29, 2016 14:30

sophiajt reviewed Aug 29, 2016
View reviewed changes

GuillaumeGomez force-pushed the rustc_metadata_diagnostics branch from a425cb0 to 1f1bf37 Compare August 30, 2016 17:33

sophiajt reviewed Aug 30, 2016
View reviewed changes

src/librustc_metadata/diagnostics.rs Outdated

Copy link

Contributor

sophiajt Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be get_pimientos?

GuillaumeGomez added 5 commits August 30, 2016 23:19

Add E0466 error explanation

3401f4e

Add E0467 error explanation

b9eaeb1

Add E0468 error explanation

e32dad3

Add E0469 error explanation

980402c

Add E0470 error explanation

5629f7e

GuillaumeGomez force-pushed the rustc_metadata_diagnostics branch from 1f1bf37 to 354d596 Compare August 30, 2016 21:19

Add librustc metadata error codes to global check

7c53eb9

GuillaumeGomez force-pushed the rustc_metadata_diagnostics branch from 354d596 to 7c53eb9 Compare September 4, 2016 09:37

bors added a commit that referenced this pull request Sep 6, 2016

Auto merge of #36274 - Manishearth:rollup, r=Manishearth

e1d0de8

Rollup of 6 pull requests - Successful merges: #35845, #35983, #36065, #36102, #36242, #36245 - Failed merges:

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 6, 2016

Rollup merge of rust-lang#36102 - GuillaumeGomez:rustc_metadata_diagn…

d3b305e

…ostics, r=jonathandturner Rustc metadata diagnostics r? @jonathandturner

sophiajt mentioned this pull request Sep 6, 2016

Rollup of 7 pull requests #36300

Closed

Ignore this block code because of OSX failure

d4c6a61

bors added a commit that referenced this pull request Sep 19, 2016

Auto merge of #36102 - GuillaumeGomez:rustc_metadata_diagnostics, r=j…

e054701

…onathandturner Rustc metadata diagnostics r? @jonathandturner

bors merged commit d4c6a61 into rust-lang:master Sep 19, 2016

bors mentioned this pull request Sep 20, 2016

Refactor away RBML from rustc_metadata. #36551

Merged

GuillaumeGomez deleted the rustc_metadata_diagnostics branch September 20, 2016 12:00

pmatos pushed a commit to LinkiTools/rust that referenced this pull request Sep 27, 2016

Auto merge of rust-lang#36102 - GuillaumeGomez:rustc_metadata_diagnos…

6060603

…tics, r=<try> Rustc metadata diagnostics r? @jonathandturner

Uh oh!

Conversation

GuillaumeGomez commented Aug 29, 2016

Uh oh!

GuillaumeGomez commented Aug 29, 2016

Uh oh!

sophiajt Aug 29, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Aug 30, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Aug 30, 2016

Uh oh!

sophiajt Aug 30, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Aug 30, 2016

Uh oh!

sophiajt commented Aug 30, 2016

Uh oh!

bors commented Aug 30, 2016

Uh oh!

bors commented Sep 2, 2016

Uh oh!

bors commented Sep 2, 2016

Uh oh!

GuillaumeGomez commented Sep 2, 2016

Uh oh!

bors commented Sep 2, 2016

Uh oh!

bors commented Sep 2, 2016

Uh oh!

alexcrichton commented Sep 2, 2016

Uh oh!

bors commented Sep 3, 2016

Uh oh!

bors commented Sep 3, 2016

Uh oh!

TimNN commented Sep 5, 2016

Uh oh!

bors commented Sep 5, 2016

Uh oh!

GuillaumeGomez commented Sep 8, 2016

Uh oh!

TimNN commented Sep 8, 2016

Uh oh!

GuillaumeGomez commented Sep 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Sep 8, 2016

Uh oh!

sophiajt commented Sep 12, 2016

Uh oh!

TimNN commented Sep 12, 2016

Uh oh!

sophiajt commented Sep 12, 2016

Uh oh!

sophiajt commented Sep 12, 2016

Uh oh!

GuillaumeGomez commented Sep 12, 2016

Uh oh!

GuillaumeGomez commented Sep 15, 2016

Uh oh!

sophiajt commented Sep 16, 2016

Uh oh!

GuillaumeGomez commented Sep 16, 2016

Uh oh!

TimNN commented Sep 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Sep 17, 2016

Uh oh!

sophiajt commented Sep 19, 2016

Uh oh!

bors commented Sep 19, 2016

Uh oh!

bors commented Sep 19, 2016

Uh oh!

bors commented Sep 19, 2016

GuillaumeGomez commented Sep 8, 2016 •

edited

Loading

TimNN commented Sep 17, 2016 •

edited

Loading