Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
I feel like the test can be made considerably simpler and easier to understand like this, but I guess this approach is also good. |
Member
|
@bors r=nagisa |
Collaborator
|
📌 Commit 34e1817 has been approved by |
Contributor
Author
|
@eddyb As far as I can tell the only failure is My test passes Could you please |
Member
|
@cristicbz that’s the Travis (see #36138) which is unrelated to bors/homu. Bors will get to your PR regardless of travis status and build it itself. You can track your PR status with bors here. |
Contributor
Author
Contributor
|
That error is a current bug in travis that's being looked at. |
Contributor
|
@bors rollup |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
Add test for rust-lang#14875 You can check this out in the playground https://is.gd/oVKC2T . It will fail on stable, but pass on nightly as @nagisa suggested on the issue. Fixes rust-lang#14875
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
Add test for rust-lang#14875 You can check this out in the playground https://is.gd/oVKC2T . It will fail on stable, but pass on nightly as @nagisa suggested on the issue. Fixes rust-lang#14875
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
Add test for rust-lang#14875 You can check this out in the playground https://is.gd/oVKC2T . It will fail on stable, but pass on nightly as @nagisa suggested on the issue. Fixes rust-lang#14875
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
Add test for rust-lang#14875 You can check this out in the playground https://is.gd/oVKC2T . It will fail on stable, but pass on nightly as @nagisa suggested on the issue. Fixes rust-lang#14875
bors
added a commit
that referenced
this pull request
Aug 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can check this out in the playground https://is.gd/oVKC2T . It will fail on stable, but pass on nightly as @nagisa suggested on the issue.
Fixes #14875