Add two functions to check type of given address

[achanda]

The is_v4 function returns true if the given IP is v4. The is_v6
function returns true if the IP is v6.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[achanda]

@alexcrichton I was looking for a way to filter a list of IpAddrs based on type. I thought these two functions might help. But I have a feeling now that these might not be idiomatic enough. Thoughts?

[alexcrichton]

Thanks for the PR @achanda! This seems pretty reasonable to me. I'd be fine even adding SocketAddr::{is_ipv4, is_ipv6} as well.

Thoughts @rust-lang/libs ?

Also looks like the travis failure may need to be resolved before landing.

[achanda]

@alexcrichton makes sense, I will have a PR up for those as well once I fix these tests here.

[achanda]

Looks like this needs a r+ :)

[alexcrichton]

@achanda sure yeah, just postponing to discuss the new feature in a libs triage

[achanda]

Ah, sorry for rushing!

[alexcrichton]

@rfcbot fcp merge

[alexcrichton]

I think the last piece of functionality we'd want here is a tracking issue and a specific #[unstable] tag on these methods (apart from the "catch all bucket" unstable issue for these methods), but that can happen once libs has taken a peek.

[rfcbot]

FCP proposed with disposition to merge. Review requested from:

• @BurntSushi
• @Kimundi
• @alexcrichton
• @aturon
• @brson
• @sfackler

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

[achanda]

@alexcrichton sorry, should I add the #[unstable] tag now? Not sure of the workflow, the rfcbot is new to me! :)

[alexcrichton]

@achanda sure if you'd like! This is likely to be accepted so if you want to go ahead and open an issue for this as well I can tag it and you can reference it.

Also don't worry, rfcbot is hot new technology for us too!

[achanda]

@alexcrichton done!

[alexcrichton]

@bors: r+

Thanks again @achanda

[bors]

📌 Commit 80a7a3c has been approved by alexcrichton

[bors]

⌛ Testing commit 80a7a3c with merge ead9212...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing ead9212 to master...

[rfcbot]

@alexcrichton proposal cancelled.