Skip to content

Add missing urls for io types#37165

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:bytes_url
Oct 20, 2016
Merged

Add missing urls for io types#37165
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:bytes_url

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 14, 2016

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 14, 2016

@frewsxcv orders so I execute.

@bors: delegate=kmcallister

@bors
Copy link
Collaborator

bors commented Oct 14, 2016

✌️ @kmcallister can now approve this pull request

@kmcallister
Copy link
Contributor

kmcallister commented Oct 15, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 15, 2016

📌 Commit e25d997 has been approved by kmcallister

ollie27
ollie27 reviewed Oct 15, 2016
View reviewed changes
src/libstd/io/cursor.rs
/// The standard library implements some I/O traits on various types which
/// are commonly used as a buffer, like `Cursor<Vec<u8>>` and `Cursor<&[u8]>`.
/// are commonly used as a buffer, like `Cursor<`[`Vec`]`<u8>>` and
/// `Cursor<`[`&[u8]`]`>`.
Copy link
Contributor

@ollie27 ollie27 Oct 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't put square brackets in links like this. It needs to be something like ``Cursor<[&[u8]`][bytes]`>`.` and `[bytes]: ../../std/primitive.slice.html` for this link to work.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Oct 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pay attention, thanks!

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it does work.

Copy link
Contributor

@ollie27 ollie27 Oct 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this as part of #37316.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 15, 2016

@bors: r-

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 19, 2016

@bors: r=kmcallister rollup

@bors
Copy link
Collaborator

bors commented Oct 19, 2016

📌 Commit e25d997 has been approved by kmcallister

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 19, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 19, 2016
@GuillaumeGomez
Rollup merge of rust-lang#37165 - GuillaumeGomez:bytes_url, r=kmcalli…
32820c1 
…ster

Add missing urls for io types

r? @steveklabnik
bors added a commit that referenced this pull request Oct 20, 2016
@bors
Auto merge of #37289 - GuillaumeGomez:rollup, r=GuillaumeGomez
dfd98eb 
Rollup of 7 pull requests

- Successful merges: #37165, #37187, #37241, #37283, #37285, #37287, #37288
- Failed merges:
@bors bors merged commit e25d997 into rust-lang:master Oct 20, 2016
@GuillaumeGomez GuillaumeGomez deleted the bytes_url branch October 20, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ollie27 ollie27 ollie27 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @bors @kmcallister @ollie27 @steveklabnik