run rustfmt on librustc_driver folder#37296

srinivasreddy · 2016-10-20T01:40:40Z

No description provided.

rust-highfive · 2016-10-20T01:40:53Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

srinivasreddy · 2016-10-20T01:47:49Z

@nikomatsakis LGTM. What do you think?

nikomatsakis · 2016-10-21T17:46:17Z

@bors r+ rollup

bors · 2016-10-23T02:50:59Z

☔ The latest upstream changes (presumably #37301) made this pull request unmergeable. Please resolve the merge conflicts.

jseyfried · 2016-10-23T21:51:25Z

src/librustc_driver/pretty.rs

I find this formatting confusing and hard to read.

jseyfried · 2016-10-23T21:51:57Z

src/librustc_driver/pretty.rs

Needless added line break.

jseyfried · 2016-10-23T21:52:34Z

src/librustc_driver/pretty.rs

Strange indent.

jseyfried · 2016-10-23T21:53:30Z

src/librustc_driver/pretty.rs

Strange indent.

jseyfried · 2016-10-23T21:54:58Z

src/librustc_driver/pretty.rs

Incorrect indent (looks like a rustfmt bug).

rust-lang/rustfmt#1197

jseyfried · 2016-10-23T21:56:39Z

src/librustc_driver/pretty.rs

This is very strange/confusing.

srinivasreddy · 2016-10-25T19:20:05Z

@nikomatsakis rollup pls

nrc · 2016-10-25T20:10:19Z

I filed an issue for the over-indented match arm. I think all the other issues are already known.

bors · 2016-10-30T07:11:09Z

☔ The latest upstream changes (presumably #37400) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-10-31T15:07:41Z

@bors r+ rollup

bors · 2016-10-31T15:07:42Z

📌 Commit f32ce9c has been approved by nikomatsakis

…komatsakis run rustfmt on librustc_driver folder

Rollup of 7 pull requests - Successful merges: #36849, #37059, #37296, #37316, #37484, #37485, #37495 - Failed merges:

rust-highfive assigned nikomatsakis Oct 20, 2016

jseyfried reviewed Oct 23, 2016

View reviewed changes

run rustfmt on librustc_driver folder

f32ce9c

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 1, 2016

Rollup merge of rust-lang#37296 - srinivasreddy:librustc_driver, r=ni…

ed96e4f

…komatsakis run rustfmt on librustc_driver folder

GuillaumeGomez mentioned this pull request Nov 1, 2016

Rollup of 7 pull requests #37514

Merged

bors added a commit that referenced this pull request Nov 2, 2016

Auto merge of #37514 - GuillaumeGomez:rollup, r=GuillaumeGomez

3fba503

Rollup of 7 pull requests - Successful merges: #36849, #37059, #37296, #37316, #37484, #37485, #37495 - Failed merges:

bors merged commit f32ce9c into rust-lang:master Nov 2, 2016

srinivasreddy deleted the librustc_driver branch November 2, 2016 06:50

Uh oh!

Conversation

srinivasreddy commented Oct 20, 2016

Uh oh!

rust-highfive commented Oct 20, 2016

Uh oh!

srinivasreddy commented Oct 20, 2016

Uh oh!

nikomatsakis commented Oct 21, 2016

Uh oh!

bors commented Oct 23, 2016

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

nrc Oct 25, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried Oct 23, 2016

Choose a reason for hiding this comment

Uh oh!

srinivasreddy commented Oct 25, 2016

Uh oh!

nrc commented Oct 25, 2016

Uh oh!

bors commented Oct 30, 2016

Uh oh!

nikomatsakis commented Oct 31, 2016

Uh oh!

bors commented Oct 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants