Change `Into<Vec<u8>> for String` and `Into<OsString> for PathBuf` to From#37585

leoyvens · 2016-11-04T17:55:32Z

Fixes #37561. First contribution, happy with any and all feedback!

…m impls

rust-highfive · 2016-11-04T17:55:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sfackler · 2016-11-04T18:23:57Z

LGTM - @alexcrichton the feature flag change doesn't matter, right?

alexcrichton · 2016-11-04T18:24:42Z

@bors: r+

Yeah feature flags changing is fine, thanks for the PR @leodasvacas!

bors · 2016-11-04T18:24:44Z

📌 Commit 3e4bd88 has been approved by alexcrichton

…alexcrichton Change `Into<Vec<u8>> for String` and `Into<OsString> for PathBuf` to From Fixes rust-lang#37561. First contribution, happy with any and all feedback!

Rollup of 24 pull requests - Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596 - Failed merges: #37521, #37547

…alexcrichton Change `Into<Vec<u8>> for String` and `Into<OsString> for PathBuf` to From Fixes rust-lang#37561. First contribution, happy with any and all feedback!

Rollup of 24 pull requests - Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596 - Failed merges: #37521, #37547

Change Into<Vec<u8>> for String and Into<OsString> for PathBuf to Fro…

3e4bd88

…m impls

rust-highfive assigned sfackler Nov 4, 2016

alexcrichton mentioned this pull request Nov 4, 2016

Rollup of 24 pull requests #37597

Merged

sophiajt mentioned this pull request Nov 5, 2016

Rollup of 17 pull requests #37604

Closed

bors merged commit 3e4bd88 into rust-lang:master Nov 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change `Into<Vec<u8>> for String` and `Into<OsString> for PathBuf` to From#37585