Remove incorrect statement about the reference.#37820
Closed
steveklabnik wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove incorrect statement about the reference.#37820steveklabnik wants to merge 1 commit intorust-lang:masterfrom
steveklabnik wants to merge 1 commit intorust-lang:masterfrom
Conversation
This is not true.
Contributor
|
@steveklabnik: no appropriate reviewer found, use r? to override |
Contributor
Author
|
Or at least, I feel like this phrasing doesn't accurately convey what's going on. It might be incomplete, but it's not inaccurate. Maybe a replacement sentence is better? @rust-lang/docs |
Member
|
No need to debate upon this. Thanks for catching this @steveklabnik! @bors: r+ rollup |
Collaborator
|
📌 Commit 963ef08 has been approved by |
Contributor
|
Wait, this is completely wrong. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 17, 2016
…ence-comment, r=GuillaumeGomez Remove incorrect statement about the reference. This is not true.
Contributor
Author
|
@bors: r- This morning, looking at it again, I agree with @petrochenkov ; let me re-word this properly. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 23, 2016
…ence-comment, r=GuillaumeGomez Clarify the reference's status. The former wording only gave part of the picture, we want to be crystal clear about this. /cc @petrochenkov, who had concerns about rust-lang#37820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not true.