Merged
Conversation
frewsxcv
reviewed
Dec 7, 2016
| /// The inherent methods of `Rc` are all associated functions, which means | ||
| /// that you have to call them as e.g. `Rc::get_mut(&value)` instead of | ||
| /// `value.get_mut()`. This avoids conflicts with methods of the inner | ||
| /// that you have to call them as e.g. [`Rc::get_mut(&value)`][get_mut] instead of |
Contributor
There was a problem hiding this comment.
it looks like the rest of the file uses 79 (or 80?) characters for line length. Can you make this line match?
Member
Author
There was a problem hiding this comment.
In a lot of places, it goes beyond 80 columns so I don't see it as an issue?
frewsxcv
reviewed
Dec 7, 2016
| //! | ||
| //! If our requirements change, and we also need to be able to traverse from | ||
| //! `Owner` to `Gadget`, we will run into problems. An `Rc` pointer from `Owner` | ||
| //! `Owner` to `Gadget`, we will run into problems. An [`Rc`] pointer from `Owner` |
Contributor
There was a problem hiding this comment.
Same comment as https://github.com/rust-lang/rust/pull/38189/files#r91204663
Member
Author
There was a problem hiding this comment.
And same answer. :p
Contributor
|
r=me after line lengths are fixed |
Contributor
|
You're right, looks like it's 100 in other places in this file. @bors r+ rollup |
Collaborator
|
📌 Commit 5caec61 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 7, 2016
Add missing links to Rc doc r? @frewsxcv
bors
added a commit
that referenced
this pull request
Dec 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @frewsxcv