Library stabilizations/deprecations for 1.15 release#38369

aturon · 2016-12-14T20:42:24Z

Stabilized:

std::iter::Iterator::{min_by, max_by}
std::os::*::fs::FileExt
std::sync::atomic::Atomic*::{get_mut, into_inner}
std::vec::IntoIter::{as_slice, as_mut_slice}
std::sync::mpsc::Receiver::try_iter
std::os::unix::process::CommandExt::before_exec
std::rc::Rc::{strong_count, weak_count}
std::sync::Arc::{strong_count, weak_count}
std::char::{encode_utf8, encode_utf16}
std::cell::Ref::clone
std::io::Take::into_inner

Deprecated:

std::rc::Rc::{would_unwrap, is_unique}
std::cell::RefCell::borrow_state

Closes #23755
Closes #27733
Closes #27746
Closes #27784
Closes #28356
Closes #31398
Closes #34931
Closes #35601
Closes #35603
Closes #35918
Closes #36105

rust-highfive · 2016-12-14T20:42:36Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2016-12-14T20:43:00Z

r? @alexcrichton

I'll push up a final commit to take care of any remaining build failures before sending to bors, but you can go ahead and review.

aturon · 2016-12-14T20:44:25Z

cc @rust-lang/libs

alexcrichton · 2016-12-14T23:20:35Z

r+ from me, feel free to r=me and follow bors failures

Looks like make tidy may be failing though?

achanda · 2016-12-14T23:28:19Z

Can we add #36949 here?

aturon · 2016-12-14T23:29:58Z

@achanda No, that issue has not entered its "final comment period" for stabilization yet -- we like to make sure that people are aware that the feature is headed for stabilization and have a chance to make final comments before we land it. I expect we'll pick it up for the 1.16 release.

achanda · 2016-12-14T23:30:45Z

Got it, thanks @aturon!

aturon · 2016-12-14T23:43:50Z

@bors r=alexcrichton

bors · 2016-12-14T23:43:51Z

📌 Commit f4c3004 has been approved by alexcrichton

frewsxcv · 2016-12-15T03:00:37Z

It looks like there are Travis errors?

aturon · 2016-12-15T03:43:10Z

@bors r=alexcrichton

bors · 2016-12-15T03:43:11Z

📌 Commit 14396c2 has been approved by alexcrichton

frewsxcv · 2016-12-15T04:51:22Z

Looks like there are a couple more errors.

aturon · 2016-12-15T04:55:28Z

@bors r=alexcrichton

bors · 2016-12-15T04:55:30Z

📌 Commit fd8191d has been approved by alexcrichton

frewsxcv · 2016-12-15T06:13:27Z

More errors again. I'll stop responding if you've got it under control :)

bluss · 2016-12-15T10:37:01Z

I'm unsure about ExactSizeIterator::is_empty #35428

aturon · 2016-12-15T18:17:57Z

I'm removing the is_empty stabilization, to allow more time for discussion.

bors · 2016-12-16T11:40:49Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-12-16T17:21:56Z

@bors: retry

…

On Fri, Dec 16, 2016 at 3:40 AM, bors ***@***.***> wrote: 💔 Test failed - auto-win-msvc-64-opt <https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/6421> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#38369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95H44BpE0IDiZDYV0I83cgWIY39J3ks5rInjDgaJpZM4LNZA6> .

bors · 2016-12-16T17:22:03Z

⌛ Testing commit 4ab77b7 with merge cc44dbe...

bors · 2016-12-16T17:30:08Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-12-16T17:35:29Z

@bors: retry

…

On Fri, Dec 16, 2016 at 9:30 AM, bors ***@***.***> wrote: 💔 Test failed - auto-win-msvc-64-opt-rustbuild <https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/3304> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#38369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95PeLLz_D86CXXBhMUcvz2zi_dRqgks5rIsqigaJpZM4LNZA6> .

bors · 2016-12-16T17:35:51Z

⌛ Testing commit 4ab77b7 with merge 3361a9d...

bors · 2016-12-16T17:39:31Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-12-16T17:43:35Z

@bors: retry

…

On Fri, Dec 16, 2016 at 9:39 AM, bors ***@***.***> wrote: 💔 Test failed - auto-win-msvc-64-opt <https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/6441> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#38369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95CXP_6vQ0Wtjrub6l4WX5JwIoVYIks5rIszVgaJpZM4LNZA6> .

bors · 2016-12-16T19:29:58Z

⌛ Testing commit 4ab77b7 with merge 5e72a3e...

bors · 2016-12-16T20:34:23Z

💔 Test failed - auto-win-msvc-64-opt

aturon · 2016-12-17T03:33:13Z

@bors r=alexcrichton

bors · 2016-12-17T03:33:14Z

📌 Commit f720b8b has been approved by alexcrichton

aturon · 2016-12-17T03:43:42Z

@bors r=alexcrichton

bors · 2016-12-17T03:43:43Z

📌 Commit 9a5cef4 has been approved by alexcrichton

bors · 2016-12-18T13:32:21Z

💔 Test failed - auto-win-msvc-64-cargotest

alexcrichton · 2016-12-18T17:37:16Z

@bors: retry

…

On Sun, Dec 18, 2016 at 5:32 AM, bors ***@***.***> wrote: 💔 Test failed - auto-win-msvc-64-cargotest <https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/2642> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#38369 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95KCocPMpqIPWilmL7ZdUdfnEeUJQks5rJTXngaJpZM4LNZA6> .

bors · 2016-12-18T17:37:25Z

⌛ Testing commit 9a5cef4 with merge 1f965cc...

Library stabilizations/deprecations for 1.15 release Stabilized: - `std::iter::Iterator::{min_by, max_by}` - `std::os::*::fs::FileExt` - `std::sync::atomic::Atomic*::{get_mut, into_inner}` - `std::vec::IntoIter::{as_slice, as_mut_slice}` - `std::sync::mpsc::Receiver::try_iter` - `std::os::unix::process::CommandExt::before_exec` - `std::rc::Rc::{strong_count, weak_count}` - `std::sync::Arc::{strong_count, weak_count}` - `std::char::{encode_utf8, encode_utf16}` - `std::cell::Ref::clone` - `std::io::Take::into_inner` Deprecated: - `std::rc::Rc::{would_unwrap, is_unique}` - `std::cell::RefCell::borrow_state` Closes #23755 Closes #27733 Closes #27746 Closes #27784 Closes #28356 Closes #31398 Closes #34931 Closes #35601 Closes #35603 Closes #35918 Closes #36105

bors · 2016-12-18T22:06:23Z

rust-highfive assigned sfackler Dec 14, 2016

rust-highfive assigned alexcrichton and unassigned sfackler Dec 14, 2016

aturon force-pushed the stab-1.15 branch from 5f7cdd8 to 2fe07a3 Compare December 14, 2016 21:02

aturon force-pushed the stab-1.15 branch from 2fe07a3 to f4c3004 Compare December 14, 2016 23:35

aturon force-pushed the stab-1.15 branch 3 times, most recently from c5a33f4 to 14396c2 Compare December 15, 2016 03:18

aturon force-pushed the stab-1.15 branch from 14396c2 to fd8191d Compare December 15, 2016 04:54

aturon force-pushed the stab-1.15 branch from fd8191d to 88b8b1e Compare December 15, 2016 06:18

aturon force-pushed the stab-1.15 branch from 88b8b1e to 9ad992a Compare December 15, 2016 18:17

aturon force-pushed the stab-1.15 branch from 9ad992a to 7b2f053 Compare December 15, 2016 18:23

aturon force-pushed the stab-1.15 branch from 4ab77b7 to f720b8b Compare December 17, 2016 03:32

Address fallout

9a5cef4

aturon force-pushed the stab-1.15 branch from f720b8b to 9a5cef4 Compare December 17, 2016 03:42

bors merged commit 9a5cef4 into rust-lang:master Dec 18, 2016

This was referenced Dec 18, 2016

Implement fmt::Debug for all structures in libstd. #38006

Merged

Miscellaneous cleanup/refactoring in resolve and syntax::ext #38171

Closed

NickeZ mentioned this pull request Jan 19, 2017

Allow arguments in shell option alacritty/alacritty#274

Closed

Uh oh!

Conversation

aturon commented Dec 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Dec 14, 2016

Uh oh!

aturon commented Dec 14, 2016

Uh oh!

aturon commented Dec 14, 2016

Uh oh!

alexcrichton commented Dec 14, 2016

Uh oh!

achanda commented Dec 14, 2016

Uh oh!

aturon commented Dec 14, 2016

Uh oh!

achanda commented Dec 14, 2016

Uh oh!

aturon commented Dec 14, 2016

Uh oh!

bors commented Dec 14, 2016

Uh oh!

frewsxcv commented Dec 15, 2016

Uh oh!

aturon commented Dec 15, 2016

Uh oh!

bors commented Dec 15, 2016

Uh oh!

frewsxcv commented Dec 15, 2016

Uh oh!

aturon commented Dec 15, 2016

Uh oh!

bors commented Dec 15, 2016

Uh oh!

frewsxcv commented Dec 15, 2016

Uh oh!

bluss commented Dec 15, 2016

Uh oh!

aturon commented Dec 15, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

alexcrichton commented Dec 16, 2016 via email

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

alexcrichton commented Dec 16, 2016 via email

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

alexcrichton commented Dec 16, 2016 via email

Uh oh!

bors commented Dec 16, 2016

Uh oh!

bors commented Dec 16, 2016

Uh oh!

aturon commented Dec 17, 2016

Uh oh!

bors commented Dec 17, 2016

Uh oh!

aturon commented Dec 17, 2016

Uh oh!

bors commented Dec 17, 2016

Uh oh!

bors commented Dec 18, 2016

Uh oh!

alexcrichton commented Dec 18, 2016 via email

Uh oh!

bors commented Dec 18, 2016

Uh oh!

bors commented Dec 18, 2016

Uh oh!

Reviewers

Assignees

Labels

aturon commented Dec 14, 2016 •

edited

Loading