Fix fs tests on Windows systems with non-english locales.#38536
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 26, 2016
Merged
Fix fs tests on Windows systems with non-english locales.#38536bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Does this fix #34628? |
5f6d3ac to
23cfcdd
Compare
Contributor
Author
|
@petrochenkov It does now. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 23cfcdd has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 26, 2016
Fix fs tests on Windows systems with non-english locales. Fixes #34628 r? @alexcrichton
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
|
@retep998 how did that branch name came to be? 😂 |
Member
|
@daschl I've stumbled across this error on a german locale, and the 🐇 has fixed it :) |
38 tasks
Contributor
|
Can confirm, with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34628
r? @alexcrichton