Implement placement-in protocol for Vec#38551
Conversation
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
The implementation looks fine to me. We might want to return a Otherwise its mostly for somebody from libs team to r+ it. |
aidanhs
force-pushed
the
aphs-vec-in-place
branch
from
9ae3328 to
75fe66e
Compare
|
@nagisa ah thanks, I did wonder about that since returning a reference seems strictly more useful than not, but decided to follow in the footsteps of |
aturon
added
the
T-libs-api
|
cc @rust-lang/libs |
|
@rfcbot fcp merge |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
@bors r+ |
|
📌 Commit 75fe66e has been approved by |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @alexcrichton, I wasn't able to add the |
Implement placement-in protocol for `Vec` Follow-up of #32366 per comment at #30172 (comment), updating to latest rust, leaving @apasel422 as author and putting myself as committer. I've removed the implementation of `push` in terms of place to make this PR more conservative.
|
☀️ Test successful - status-appveyor, status-travis |
Implement placement-in protocol for `BinaryHeap` Related to #30172, and loosley based on #38551. At the moment, this PR is in a pretty rough state, but I wanted to get some feedback to see if I'm going in the right direction. I hope the Mentor label of #30172 is still applicable, even though it's a year old 😄
10 participants
Follow-up of #32366 per comment at #30172 (comment), updating to latest rust, leaving @apasel422 as author and putting myself as committer.
I've removed the implementation of
pushin terms of place to make this PR more conservative.