Skip to content

resolve: don't unused_qualifications-check global paths#38817

Merged
bors merged 1 commit intorust-lang:masterfrom
jseyfried:improve_unused_qualification_lint
Jan 5, 2017
Merged

resolve: don't unused_qualifications-check global paths#38817
bors merged 1 commit intorust-lang:masterfrom
jseyfried:improve_unused_qualification_lint

Conversation

@jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Jan 4, 2017

We started unused_qualifications-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc

@jseyfried
Copy link
Contributor Author

jseyfried commented Jan 4, 2017 •
edited
Loading

The macros 1.1 system currently not provide enough span info to unused_qualifications-check only unexpanded global paths.
Improving the span info enough to fix this is doable but I'd rather we not have to backport it.

@jseyfried jseyfried mentioned this pull request Jan 4, 2017
Closed
@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 4, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 4, 2017

📌 Commit 7dcacf1 has been approved by petrochenkov

@jseyfried jseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2017
@killercup
Copy link
Contributor

killercup commented Jan 4, 2017

FYI this could also fix #38444 (which is already closed)

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 4, 2017
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 4, 2017

Accepted for beta. Small patch, regression. cc @rust-lang/compiler

@alexcrichton
Copy link
Member

alexcrichton commented Jan 4, 2017

@bors: p=1

(this is approved, we'll want to backport)

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

⌛ Testing commit 7dcacf1 with merge a39fc9c...

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 5, 2017 via email

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

⌛ Testing commit 7dcacf1 with merge a10ce81...

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 5, 2017 via email

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

⌛ Testing commit 7dcacf1 with merge cdd72e7...

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

💔 Test failed - status-travis

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 5, 2017 •
edited
Loading

@bors retry

  • odd timeouts building LLVM?

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

⌛ Testing commit 7dcacf1 with merge ea2d41e...

bors added a commit that referenced this pull request Jan 5, 2017
@bors
Auto merge of #38817 - jseyfried:improve_unused_qualification_lint, r…
ea2d41e 
…=petrochenkov

resolve: don't `unused_qualifications`-check global paths

We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc
@bors
Copy link
Collaborator

bors commented Jan 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing ea2d41e to master...

@bors bors merged commit 7dcacf1 into rust-lang:master Jan 5, 2017
@nikomatsakis nikomatsakis mentioned this pull request Jan 6, 2017
Merged
17 tasks
@jseyfried jseyfried deleted the improve_unused_qualification_lint branch January 6, 2017 18:23
@alexcrichton alexcrichton mentioned this pull request Jan 7, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrc nrc

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jseyfried @petrochenkov @bors @killercup @nikomatsakis @alexcrichton @nrc