Conversation
RELEASES.md
Outdated
There was a problem hiding this comment.
Wrong issue/PR number. This refers to an issue titled "Using $crate with a proc macro"
RELEASES.md
Outdated
There was a problem hiding this comment.
Ah this PR didn't actually change copy_from_slice (but changed impl Read for &[u8]), so that it special cases the single byte read case.
RELEASES.md
Outdated
There was a problem hiding this comment.
As written this seems identical to the change four bullet points up. Granted, the PRs do basically the same thing, but throwing in a "more" somewhere would help — and indeed the linked PR is titled "Avoid more unnecessary ...".
RELEASES.md
Outdated
There was a problem hiding this comment.
This was already mentioned in 1.14 release notes.
RELEASES.md
Outdated
RELEASES.md
Outdated
RELEASES.md
Outdated
There was a problem hiding this comment.
Maybe add a note about the upcoming struct reorder by @camlorn ?
There was a problem hiding this comment.
Once
PeekablereturnsNoneit always does
This should be: if peekable peeks a None, it will return that same None in peek or next without querying the underlying iterator. Peekable is still not fused.
|
All comments addressed. Thanks for review. @est31 re struct reordering, in these I don't mention any work in progress, only what's usable on stable. |
RELEASES.md
Outdated
There was a problem hiding this comment.
Hm, yeah. Maybe we should wait until the next release for this bullet.
|
@bors: r+ |
|
📌 Commit c6b73d2 has been approved by |
RELEASES.md
Outdated
There was a problem hiding this comment.
"with the brace" sounds weird. "with curly braces"?
RELEASES.md
Outdated
There was a problem hiding this comment.
The link target is right but the label is wrong (but it matches the link, so this doesn't actually matter).
RELEASES.md
Outdated
There was a problem hiding this comment.
This link and the next one are swapped.
RELEASES.md
Outdated
There was a problem hiding this comment.
It is just custom derive, not "including" custom derive, right?
There was a problem hiding this comment.
I don't know the details I'm afraid, but I'll say that.
|
Thanks for the review @durka. |
|
@bors r+ |
|
📌 Commit a0a4af1 has been approved by |
|
⌛ Testing commit a0a4af1 with merge a58c6f6... |
|
💔 Test failed - status-travis |
1.15 release notes [Rundered](https://github.com/brson/rust/blob/relnotes/RELEASES.md#version-1150-2017-02-02). Lots of good stuff this release! Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿 r? @steveklabnik
|
… On Fri, Jan 20, 2017 at 4:38 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/193714169>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38966 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95F6z6w_iYYtlwt2Ls-FfAfO_3kkyks5rUKqsgaJpZM4Lf3p4>
.
|
|
⌛ Testing commit a0a4af1 with merge 8371487... |
|
@bors: retry
|
|
⌛ Testing commit a0a4af1 with merge 5bc4c06... |
|
@bors: retry
|
|
⌛ Testing commit a0a4af1 with merge 43f0020... |
|
@bors: retry
|
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
|
⌛ Testing commit a0a4af1 with merge 7b797c2... |
|
@bors: retry
|
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
|
The link for "Rust supports the MSP430" seems to be formatted incorrectly. |
Rundered.
Lots of good stuff this release!
Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿
r? @steveklabnik