Stabilize static lifetime in statics#39265
Conversation
|
@est31 nice |
|
☔ The latest upstream changes (presumably #39282) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. |
|
☔ The latest upstream changes (presumably #39305) made this pull request unmergeable. Please resolve the merge conflicts. |
est31
force-pushed
the
master
branch
2 times, most recently
from
8ac8f0d to
35191d0
Compare
|
Rebased on top of @eddyb 's PR. Its really great to see how the PR made this change much easier, so it must have been a good refactor! |
|
ping @nrc, would be a neat feature for 1.17! |
|
@alexcrichton its currently blocked by #37928 |
|
☔ The latest upstream changes (presumably #39563) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Now that beta branched, I would like to ask for beta backport nomination, so that already 1.16 would have it stabilized. |
alexcrichton
added
the
beta-nominated
|
Backporting stabilizations is incredibly rare; I would prefer we didn't.
…On Sun, Feb 5, 2017 at 12:17 PM, est31 ***@***.***> wrote:
Now that beta branched, I would like to ask for beta backport nomination,
so that already 1.16 would have it stabilized.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39265 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsinz7uaODUek9-kH2vDy48sM0xfYfks5rZgQlgaJpZM4LrsNh>
.
|
|
@bors: r+ I would also recommend against backporting - I don't think we should reduce stabilisation time in general. |
|
📌 Commit 0361dcf has been approved by |
|
⌛ Testing commit 0361dcf with merge 443866e... |
|
💔 Test failed - status-travis |
|
@bors: r=nrc |
|
📌 Commit 1c8cb8a has been approved by |
|
#37928 is not yet closed, how is this being merged? |
|
@bors: r- |
est31
force-pushed
the
master
branch
2 times, most recently
from
85accdc to
f8b6108
Compare
|
The documentation PR got merged, this is ready to be r+ed! |
|
📌 Commit f8b6108 has been approved by |
Stabilize static lifetime in statics Stabilize the "static_in_const" feature. Blockers before this PR can be merged: * [x] The [FCP with inclination to stabilize](#35897 (comment)) needs to be over. FCP lasts roughly three weeks, so will be over at Jan 25, aka this thursday. * [x] Documentation needs to be added (#37928) Closes #35897.
|
☀️ Test successful - status-appveyor, status-travis |
|
Removing beta nomination as sentiment seems to be to not backport (also see #35897) |
alexcrichton
removed
the
beta-nominated
7 participants
Stabilize the "static_in_const" feature. Blockers before this PR can be merged:
Closes #35897.