Merged
Conversation
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit abba076 has been approved by |
Member
Author
|
@bors: r- |
GuillaumeGomez
force-pushed
the
join_paths-url
branch
from
abba076 to
3022614
Compare
Member
Author
|
@bors: r=frewsxcv |
Collaborator
|
📌 Commit 3022614 has been approved by |
Member
Author
|
@bors: rollup |
frewsxcv
reviewed
Feb 8, 2017
| /// | ||
| /// Returns an `Err` (containing an error message) if one of the input | ||
| /// `Path`s contains an invalid character for constructing the `PATH` | ||
| /// Returns an [`Err`][err] (containing an error message) if one of the input |
Contributor
There was a problem hiding this comment.
I think you could have also just done:
[`Err`][] (blah blah)
[`Err`]: https://foo.bar
Contributor
There was a problem hiding this comment.
But what you have is fine 👍
Member
Author
There was a problem hiding this comment.
I find it a bit less clear. 😉
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 9, 2017
…ewsxcv Add missing urls on join_paths r? @frewsxcv
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 9, 2017
…ewsxcv Add missing urls on join_paths r? @frewsxcv
bors
added a commit
that referenced
this pull request
Feb 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @frewsxcv