rustbuild: Retry downloads by default#40060
Conversation
Don't rely on curl's --retry, it appears to not work for some errors like SSL errors.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 30b0ed0 has been approved by |
|
This is tangential to your PR, but is there any way to prevent this from happening? https://travis-ci.org/rust-lang/rust/jobs/204633420 It was just stalling for 30 minutes due to, presumably, network issues |
|
Unfortunately not that I know of, that was likely cloning just at a really slow rate |
|
@bors p=15 |
|
@bors p=7 |
|
⌛ Testing commit 30b0ed0 with merge ec9eca5... |
|
💔 Test failed - status-travis |
|
@bors retry |
|
⌛ Testing commit 30b0ed0 with merge a3b807d... |
|
💔 Test failed - status-travis |
|
@bors retry |
rustbuild: Retry downloads by default Don't rely on curl's --retry, it appears to not work for some errors like SSL errors.
rustbuild: Retry downloads by default Don't rely on curl's --retry, it appears to not work for some errors like SSL errors.
|
Note: both travis failures are #39003. |
|
💔 Test failed - status-travis |
|
… On Fri, Feb 24, 2017 at 3:24 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/205103806>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40060 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95DfIkSsHD48fNgB6B0yIjReUuojzks5rf0p5gaJpZM4MKE3y>
.
|
rustbuild: Retry downloads by default Don't rely on curl's --retry, it appears to not work for some errors like SSL errors.
|
☀️ Test successful - status-appveyor, status-travis |
Don't rely on curl's --retry, it appears to not work for some errors like SSL
errors.