Merged
Conversation
Mark-Simulacrum
changed the title
Contributor
|
Nice catch! This is indeed an oversight I have made. If you can merge the 2 blocks, that would be excellent (and I'll r+ it). |
Member
Author
|
Pushed a unification and another commit which removes references to |
Mark-Simulacrum
changed the title
Contributor
|
nit: I would rather have a name like r+ modulo nit. |
Mark-Simulacrum
force-pushed
the
normalization-followup
branch
from
3057eb7 to
403ae37
Compare
Member
Author
|
Changed name to suggested |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 403ae37 has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
…wup, r=arielb1 Fix normalization error Follows rust-lang#40163. I don't know whether this is good, but seems logical. [This block of code](https://github.com/rust-lang/rust/blob/ba07bd5d23aced6d4baa5696213b11ca832c1a5d/src/librustc_typeck/check/mod.rs#L2110-L2138) doesn't contain a call to `normalize_associated_types_in`, while [this](https://github.com/rust-lang/rust/blob/master/src/librustc_typeck/check/mod.rs#L2027-L2028) block does, and is nearly identical. Ideally these two blocks should be unified into one, but since the change doesn't seem trivial and I'm unsure if this patch will be accepted it hasn't been done yet. r? @arielb1
bors
added a commit
that referenced
this pull request
Mar 9, 2017
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #40163. I don't know whether this is good, but seems logical.
This block of code doesn't contain a call to
normalize_associated_types_in, while this block does, and is nearly identical.Ideally these two blocks should be unified into one, but since the change doesn't seem trivial and I'm unsure if this patch will be accepted it hasn't been done yet.
r? @arielb1