add sort_unstable to unstable book#40586
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 17, 2017
Merged
Conversation
Contributor
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
A bit of a pipe dream, but it'd be cool if we had some sort of lint to make sure all unstable features are in the unstable book @bors r+ rollup |
Collaborator
|
📌 Commit 3d01e1a has been approved by |
Member
|
Oh are we gonna track all unstable library features as well? We may be missing quite a few of those... (I also figured that unstable library features would just have API docs) |
Contributor
I'm in favor of adding entries of all unstable things into the unstable book, though I don't feel strongly. For unstable library features, the body of that particular page (e.g. the one in the pull request) could link just directly to the API docs. |
Contributor
Author
|
Ah yeah, I forgot about the library vs non-library distinction here.
Basically, same as Corey; I don't feel super strongly about it, but it is
kinda nice to be able to browse _all_ unstable features.
…On Thu, Mar 16, 2017 at 5:57 PM, Corey Farwell ***@***.***> wrote:
Oh are we gonna track all unstable library features as well?
I'm in favor of adding entries of all unstable things into the unstable
book, though I don't feel strongly. For unstable library features, the body
of that particular page (e.g. the one in the pull request) could link just
directly to the API docs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40586 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsislRFxJBiNIEgjqC9M1ocAxpuUY2ks5rmbBDgaJpZM4Mf7Ch>
.
|
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #40585