Add example to std::process::abort#40904
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Nope, as you can see, @rust-highfive has your back 😄 that said, let's assign this to me, not brian:
💯 |
steveklabnik
left a comment
There was a problem hiding this comment.
one tiny thing, and then this is good to go! 🎊
src/libstd/process.rs
Outdated
| /// to run. | ||
| /// | ||
| /// # Examples | ||
| /// ``` |
There was a problem hiding this comment.
could you add another /// above this line, please?
There was a problem hiding this comment.
Thanks for all the time you spent to help me!
There was a problem hiding this comment.
No problem! Very glad to do so.
|
Looks great, thanks! Travis found an issue though: https://travis-ci.org/rust-lang/rust/jobs/216364459#L564-L566 these three lines have trailing whitespace. Can you remove them? |
|
Fixed. Thanks again! @steveklabnik Travis fails again but I don't understand why what I have done make it crash. Reading the log does not help me: https://api.travis-ci.org/jobs/216373325/log.txt?deansi=true It ends with: |
|
Looks like a spurious failure; I'm going to retry it. |
src/libstd/process.rs
Outdated
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ``` |
There was a problem hiding this comment.
This needs to be changed to ```no_run so it doesn't try to run this code as a test.
There was a problem hiding this comment.
Ok thanks, done!
|
@steveklabnik It passes now :) |
|
@bors: r+ rollup wonderful, thank you so much! |
|
📌 Commit 1be84ce has been approved by |
|
Thanks to you I learned a lot with this (really small) PR! I'm ready for better PR now. |
|
Awesome :D
|
Add example to std::process::abort This is a first step in order to complete this issue: rust-lang#29370 I submitted this PR with the help of @steveklabnik More info here: rust-lang#29370 (comment) It's my first PR on Rust, I'm learning how to contribute: Should I ping someone? I will post another PR with a more complicated example soon, I prefer send it separately (cause maybe I made some mistakes).
This is a first step in order to complete this issue: #29370
I submitted this PR with the help of @steveklabnik More info here: #29370 (comment)
It's my first PR on Rust, I'm learning how to contribute: Should I ping someone? I will post another PR with a more complicated example soon, I prefer send it separately (cause maybe I made some mistakes).