Merged
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
steveklabnik
suggested changes
Apr 1, 2017
src/libcore/option.rs
Outdated
| /// | ||
| /// The iterator yields one value if the [`Option`] is a [`Some`] variant, otherwise none. | ||
| /// | ||
| /// This `struct` is created by [`Option::iter`] function. |
src/libcore/option.rs
Outdated
| /// An iterator over a reference of the contained item in an [`Option`]. | ||
| /// An iterator over a reference to the [`Some`] variant of an [`Option`]. | ||
| /// | ||
| /// The iterator yields one value if the [`Option`] is a [`Some`] variant, otherwise none. |
Contributor
There was a problem hiding this comment.
can you remove "variant" here, it sounds more natural without it to me.
src/libcore/option.rs
Outdated
| /// | ||
| /// The iterator yields one value if the [`Option`] is a [`Some`] variant, otherwise none. | ||
| /// | ||
| /// This `struct` is created by [`Option::iter_mut`] function. |
Contributor
There was a problem hiding this comment.
same two comments here
src/libcore/option.rs
Outdated
| /// | ||
| /// The iterator yields one value if the [`Option`] is a [`Some`] variant, otherwise none. | ||
| /// | ||
| /// This `struct` is created by [`Option::into_iter`] function. |
frewsxcv
added
the
A-docs
Contributor
Author
|
@steveklabnik Thanks for the review. I've made some changes here. |
steveklabnik
approved these changes
Apr 2, 2017
Contributor
|
@bors: r+ rollup thank you! |
Collaborator
|
📌 Commit 4c9f8ae has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
bors
added a commit
that referenced
this pull request
Apr 5, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #29366
Improve
optionAPI docs forIntoIterstructIterstructIterMutstructr? @steveklabnik